OpenVZ Forum: Devel » [PATCH 1/2] Don't forget to unlock uids

Home » Mailing lists » Devel » [PATCH 1/2] Don't forget to unlock uids_mutex on error paths

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH 1/2] Don't forget to unlock uids_mutex on error paths [message #23730 is a reply to message #23728]

Fri, 23 November 2007 13:52

Ingo Molnar
Messages: 51
Registered: December 2005

Member

* Dhaval Giani <dhaval@linux.vnet.ibm.com> wrote:

> On Wed, Nov 21, 2007 at 01:49:33PM +0300, Pavel Emelyanov wrote:
> > The commit
> > 
> > commit 5cb350baf580017da38199625b7365b1763d7180
> > Author: Dhaval Giani <dhaval@linux.vnet.ibm.com>
> > Date:   Mon Oct 15 17:00:14 2007 +0200
> > 
> >     sched: group scheduling, sysfs tunables
> > 
> > introduced the uids_mutex and the helpers to lock/unlock it.
> > Unfortunately, the error paths of alloc_uid() were not patched
> > to unlock it.

oops!

> Thanks for catching it. Looks good to me. Ingo, could you please pick 
> these up?

yep - added.

	Ingo

Report message to a moderator

[Message index]

		[PATCH 1/2] Don't forget to unlock uids_mutex on error paths By: Pavel Emelianov on Wed, 21 November 2007 10:49
		Re: [PATCH 1/2] Don't forget to unlock uids_mutex on error paths By: Dhaval Giani on Fri, 23 November 2007 13:12
		Re: [PATCH 1/2] Don't forget to unlock uids_mutex on error paths By: Ingo Molnar on Fri, 23 November 2007 13:52

Previous Topic:	[PATCH][UNIX] Move the unix sock iterators in to proper place
Next Topic:	[PATCH net-2.6.25] Name magic constants in sock_wake_async()

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Wed Nov 26 14:36:12 GMT 2025

Total time taken to generate the page: 0.31671 seconds