OpenVZ Forum: Devel » [PATCH] Clean the ip_sockglue.c from some ugly ifdefs

Home » Mailing lists » Devel » [PATCH] Clean the ip_sockglue.c from some ugly ifdefs

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH] Clean the ip_sockglue.c from some ugly ifdefs [message #22797 is a reply to message #22698]

Thu, 01 November 2007 16:31

Arnaldo Carvalho de M is currently offline

Arnaldo Carvalho de M
Messages: 27
Registered: October 2007

Junior Member

Em Thu, Nov 01, 2007 at 06:52:34PM +0300, Pavel Emelyanov escreveu:
> The #idfed CONFIG_IP_MROUTE is sometimes places inside the if-s,
> which looks completely bad. Similar ifdefs inside the functions
> looks a bit better, but they are also not recommended to be used.
> 
> Provide an ifdef-ed ip_mroute_opt() helper to cleanup the code.
> 
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>

Perhaps a better name would be ip_mroute_valid_opt()?

- Arnaldo

Report message to a moderator

[Message index]

		[PATCH] Clean the ip_sockglue.c from some ugly ifdefs By: Pavel Emelianov on Thu, 01 November 2007 15:52
		Re: [PATCH] Clean the ip_sockglue.c from some ugly ifdefs By: Pavel Emelianov on Thu, 01 November 2007 16:38
		Re: [PATCH] Clean the ip_sockglue.c from some ugly ifdefs By: Arnaldo Carvalho de M on Thu, 01 November 2007 16:31
		Re: [PATCH] Clean the ip_sockglue.c from some ugly ifdefs By: davem on Tue, 06 November 2007 05:32

Previous Topic:	[PATCH] decnet: "addr" module param can't be __initdata
Next Topic:	irq0 stops working

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Fri Dec 12 22:14:36 GMT 2025

Total time taken to generate the page: 0.12675 seconds