OpenVZ Forum


Home » Mailing lists » Devel » [PATCH] proc: Fix proc_kill_inodes to kill dentries on all proc superblocks
Re: [PATCH] pidns: Limit kill -1 and cap_set_all [message #22476 is a reply to message #22449] Mon, 29 October 2007 18:07 Go to previous messageGo to previous message
ebiederm is currently offline  ebiederm
Messages: 1354
Registered: February 2006
Senior Member
Kirill Korotaev <dev@openvz.org> writes:

> I dislike this patch:
> it's not scalable/efficient to travers all the tasks
> while we know the pid namespace we care about.

Well the unix way is to implement it simple and stupid and then to
optimize, where needed.  We don't currently have a per pid namespace
list of processes or tasks.

This is a trivial bug fix patch, and I wanted the review to be as
simple as possible.

I don't expect people are doing kill -1 all that frequently as it is a
bit rude.

I have no problem doing find_ge_pid and then looking in the hash table
like we do in /proc.  It likely will have fewer conflicts, but that
is a bit harder to review, and is actually more code.

Eric
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
 
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Previous Topic: [RFD] net list protected by rcu
Next Topic: dm: bounce_pfn limit added
Goto Forum:
  


Current Time: Tue Jul 15 21:08:42 GMT 2025

Total time taken to generate the page: 0.05510 seconds