OpenVZ Forum


Home » Mailing lists » Devel » [PATCH 0/4] Diet struct sk_buff a bit
Re: [PATCH 1/4] Use the skb_set_queue_mapping where appropriate [message #22125 is a reply to message #22044] Mon, 22 October 2007 00:01 Go to previous messageGo to previous message
davem is currently offline  davem
Messages: 463
Registered: February 2006
Senior Member
From: Pavel Emelyanov <xemul@openvz.org>
Date: Fri, 19 Oct 2007 13:00:52 +0400

> There's already such a helper to initialize this field.
> Use it.
> 
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>

Applied.

>  			/* reset queue_mapping to zero */
> -			skb->queue_mapping = 0;
> +			skb_set_queue_mapping(skb, 0);

This right here is a great example why I add next to no comments to
the code I write.  They are %99.999 of the time stating the obvious,
and where a comment is needed it's the code's fault and the code in
such cases could be rewritten to make what's going on more clear thus
making any commentary, again, redundant and stating the obvious.

Here the case is the former, it's of the form:

	/* Add one to 'a'! */
	a += 1;

Gee thanks for letting me know!  How insightful! :-))
 
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Previous Topic: [PATCH] ip{,6}_queue: convert to seq_file interface
Next Topic: [PATCH 0/2] CFS CGroup: cleanup & usage reporting
Goto Forum:
  


Current Time: Thu Aug 14 15:03:44 GMT 2025

Total time taken to generate the page: 0.60571 seconds