OpenVZ Forum


Home » Mailing lists » Devel » [PATCH 1/5] rtnl_unlock cleanups
Re: [PATCH 1/5] rtnl_unlock cleanups [message #21561 is a reply to message #21347] Thu, 11 October 2007 04:13 Go to previous message
davem is currently offline  davem
Messages: 463
Registered: February 2006
Senior Member
From: "Denis V. Lunev" <den@openvz.org>
Date: Fri, 5 Oct 2007 18:44:14 +0400

> There is no need to process outstanding netlink user->kernel packets
> during rtnl_unlock now. There is no rtnl_trylock in the rtnetlink_rcv
> anymore.
> 
> Normal code path is the following:
> netlink_sendmsg
>    netlink_unicast
>        netlink_sendskb
>            skb_queue_tail
>            netlink_data_ready
>                rtnetlink_rcv
>                    mutex_lock(&rtnl_mutex);
>                    netlink_run_queue(sk, qlen, &rtnetlink_rcv_msg);
>                    mutex_unlock(&rtnl_mutex);
> 
> So, it is possible, that packets can be present in the rtnl->sk_receive_queue
> during rtnl_unlock, but there is no need to process them at that moment as
> rtnetlink_rcv for that packet is pending.
> 
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> Acked-by: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>

Applied.
 
Read Message
Read Message
Previous Topic: Idle time statistics for a container
Next Topic: [PATCH 3/5] cleanup 3rd argument in netlink_sendskb
Goto Forum:
  


Current Time: Tue Nov 19 00:23:26 GMT 2024

Total time taken to generate the page: 0.15560 seconds