OpenVZ Forum


Home » Mailing lists » Devel » [PATCH] mark read_crX() asm code as volatile
Re: [PATCH] mark read_crX() asm code as volatile [message #21177 is a reply to message #21176] Wed, 03 October 2007 06:18 Go to previous messageGo to previous message
hpa is currently offline  hpa
Messages: 38
Registered: January 2007
Member
Nick Piggin wrote:
>>
>> This should work because the result gets used before reading again:
>>
>> read_cr3(a);
>> write_cr3(a | 1);
>> read_cr3(a);
>>
>> But this might be reordered so that b gets read before the write:
>>
>> read_cr3(a);
>> write_cr3(a | 1);
>> read_cr3(b);
>>
>> ?
> 
> I don't see how, as write_cr3 clobbers memory.

Because read_cr3() doesn't depend on memory, and b could be stored in a 
register.

	-hpa
 
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Previous Topic: [PATCH] Consolidate IPC namespace cleanup functions
Next Topic: [patch 0/1][NETNS49] Make af_unix autobind per namespace
Goto Forum:
  


Current Time: Tue Jul 16 17:11:42 GMT 2024

Total time taken to generate the page: 0.02904 seconds