OpenVZ Forum


Home » Mailing lists » Devel » [PATCH] net: Fix running without sysfs
Re: [PATCH] net: Fix running without sysfs [message #20855 is a reply to message #20849] Thu, 27 September 2007 00:07 Go to previous messageGo to previous message
Stephen Hemminger is currently offline  Stephen Hemminger
Messages: 37
Registered: August 2006
Member
On Wed, 26 Sep 2007 17:48:10 -0600
ebiederm@xmission.com (Eric W. Biederman) wrote:

> 
> When sysfs support is compiled out the kernel still keeps and maintains
> the kobject tree.  So it is not safe to skip our kobject reference counting or 
> to avoid becoming members of the kobject tree.  It is safe to not add
> the networking specific sysfs attributes.
> 
> This patch removes the sysfs special cases from net/core/dev.c
> renames functions from netdev_sysfs_xxxx to netdev_kobject_xxxx
> and always compiles in net-sysfs.c
> 
> net-sysfs.c is modified with a CONFIG_SYSFS guard around the parts
> that are actually sysfs specific.
> 
> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>

Acked-by: Stephen Hemminger <shemminger@linux-foundation.org>

Looks good. It also fixes a use after-free in netdev_run_todo
when !CONFIG_SYSFS

-- 
Stephen Hemminger <shemminger@linux-foundation.org>
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
 
Read Message
Read Message
Read Message
Previous Topic: [net-2.6.24][patch 0/2] Dynamically allocate the loopback
Next Topic: [PATCH] netns: Simplify the network namespace list locking rules.
Goto Forum:
  


Current Time: Sun Aug 03 22:09:15 GMT 2025

Total time taken to generate the page: 1.27444 seconds