OpenVZ Forum


Home » Mailing lists » Devel » [-mm PATCH 0/9] Memory controller introduction (v4)
Re: [-mm PATCH 4/9] Memory controller memory accounting (v4) [message #19711 is a reply to message #19514] Wed, 15 August 2007 08:44 Go to previous messageGo to previous message
yamamoto is currently offline  yamamoto
Messages: 97
Registered: July 2007
Member
> YAMAMOTO Takashi wrote:
> >> +	lock_meta_page(page);
> >> +	/*
> >> +	 * Check if somebody else beat us to allocating the meta_page
> >> +	 */
> >> +	race_mp = page_get_meta_page(page);
> >> +	if (race_mp) {
> >> +		kfree(mp);
> >> +		mp = race_mp;
> >> +		atomic_inc(&mp->ref_cnt);
> >> +		res_counter_uncharge(&mem->res, 1);
> >> +		goto done;
> >> +	}
> > 
> > i think you need css_put here.
> 
> Thats correct. We do need css_put in this path.
> 
> Thanks,
> Vaidy

v5 still seems to have the problem.

YAMAMOTO Takashi
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/containers
 
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Previous Topic: [PATCH] Add ability to print calltraces tighter on i386
Next Topic: containers mini-summit?
Goto Forum:
  


Current Time: Tue Jul 15 21:49:30 GMT 2025

Total time taken to generate the page: 0.03894 seconds