OpenVZ Forum: Devel » [PATCH] ext3: ext3_symlink should use GFP

Home » Mailing lists » Devel » [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside [message #1959 is a reply to message #1957]

Fri, 10 March 2006 08:41

dev
Messages: 1693
Registered: September 2005
Location: Moscow

Senior Member

>>+ page = find_or_create_page(mapping, 0,
>>+ mapping_gfp_mask(mapping) | gfp_mask);
>
>
>>+int page_symlink(struct inode *inode, const char *symname, int len)
>>+{
>>+ return __page_symlink(inode, symname, len, GFP_KERNEL);
>
>
> s/GFP_KERNEL/0/; if somebody has e.g. GFP_NOFS in their mapping flags,
> you end up breaking their code. We really pass extra flags to be added
> to default ones; page_symlink() should pass 0.
thanks for noticing this.
fixed and resend.

Thanks,
Kirill

Report message to a moderator

[Message index]

		[PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside By: Kirill Korotaev on Fri, 10 March 2006 08:03
		Re: [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside By: dev on Fri, 10 March 2006 08:41
		Re: [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside By: Al Viro on Fri, 10 March 2006 08:31

Previous Topic:	[Fwd: + i2o-memory-leak-in-i2o_exec_lct_modified.patch added to -mm tree]
Next Topic:	[PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside (ver. 3)

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sun Aug 03 11:13:46 GMT 2025

Total time taken to generate the page: 0.68632 seconds