OpenVZ Forum


Home » Mailing lists » Devel » + remove-the-likelypid-check-in-copy_process.patch added to -mm tree
Re: + remove-the-likelypid-check-in-copy_process.patch added to -mm tree [message #17866 is a reply to message #17837] Fri, 16 March 2007 17:02 Go to previous messageGo to previous message
Oleg Nesterov is currently offline  Oleg Nesterov
Messages: 143
Registered: August 2006
Senior Member
Sukadev Bhattiprolu wrote:

> @@ -1237,26 +1237,24 @@ static struct task_struct *copy_process(
>  		}
>  	}
>
> -	if (likely(p->pid)) {
> -		add_parent(p);
> -		tracehook_init_task(p);
> -
> -		if (thread_group_leader(p)) {
> -			pid_t pgid = process_group(current);
> -			pid_t sid = process_session(current);
> -
> -			p->signal->tty = current->signal->tty;
> -			p->signal->pgrp = pgid;
> -			set_signal_session(p->signal, process_session(current));
> -			attach_pid(p, PIDTYPE_PGID, find_pid(pgid));
> -			attach_pid(p, PIDTYPE_SID, find_pid(sid));
> +	add_parent(p);

This means that idle threads (except "swapper") are visible to for_each_process()
and do_each_thread(). Looks dangerous and somewhat strange to me.

Could you explain this change?

Oleg.

_______________________________________________
Containers mailing list
Containers@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/containers
 
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Previous Topic: Re: [ckrm-tech] [PATCH 0/2] resource control file system - aka containers on top of nsproxy!
Next Topic: [PATCH 2/2] fs: incorrect direct io error handling v8
Goto Forum:
  


Current Time: Wed Sep 10 21:14:10 GMT 2025

Total time taken to generate the page: 0.09474 seconds