OpenVZ Forum: Devel » [PATCH 1/2] iptables 32bit compat layer

Home » Mailing lists » Devel » [PATCH 1/2] iptables 32bit compat layer

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH 1/2] iptables 32bit compat layer [message #1719 is a reply to message #1688]

Mon, 20 February 2006 21:23

Andi Kleen
Messages: 33
Registered: February 2006

Member

Mishin Dmitry <dim@openvz.org> writes:

> Hello,
>
> This patch set extends current iptables compatibility layer in order to get
> 32bit iptables to work on 64bit kernel. Current layer is insufficient
> due to alignment checks both in kernel and user space tools.
>
> This patch introduces base compatibility interface for other ip_tables modules

Nice. But some issues with the implementation

+#if defined(CONFIG_X86_64)
+#define is_current_32bits() (current_thread_info()->flags & _TIF_IA32)

This should be is_compat_task(). And we don't do such ifdefs
in generic code. And what you actually need here is a
is_compat_task_with_funny_u64_alignment() (better name sought)

So I would suggest you add macros for that to the ia64 and x86-64
asm/compat.hs and perhaps a ARCH_HAS_FUNNY_U64_ALIGNMENT #define in there.

+ ret = 0;
+ switch (convert) {
+ case COMPAT_TO_USER:
+ pt = (struct ipt_entry_target *)target;

etc. that looks ugly. why can't you just define different functions
for that? We don't really need in kernel ioctl

+#ifdef CONFIG_COMPAT
+ down(&compat_ipt_mutex);
+#endif

Why does it need an own lock?

Overall the implementation looks very complicated. Are you sure
it wasn't possible to do this simpler?

-Andi

Report message to a moderator

[Message index]

		[PATCH 1/2] iptables 32bit compat layer By: Mishin Dmitry on Mon, 20 February 2006 08:10
		Re: [PATCH 1/2] iptables 32bit compat layer By: davem on Mon, 20 February 2006 08:31
		Re: [PATCH 1/2] iptables 32bit compat layer By: Arnd Bergmann on Mon, 20 February 2006 15:55
		Re: Re: [PATCH 1/2] iptables 32bit compat layer By: dim on Tue, 21 February 2006 09:04
		Re: Re: [PATCH 1/2] iptables 32bit compat layer By: Arnd Bergmann on Tue, 21 February 2006 11:56
		{get\|set}sockopt compat layer By: Mishin Dmitry on Tue, 07 March 2006 14:07
		Re: {get\|set}sockopt compat layer By: Arnd Bergmann on Tue, 07 March 2006 15:05
		Re: {get\|set}sockopt compat layer By: Mishin Dmitry on Thu, 09 March 2006 10:23
		Re: {get\|set}sockopt compat layer By: davem on Thu, 09 March 2006 23:29
		[PATCH] {get\|set}sockopt compatibility layer By: Mishin Dmitry on Fri, 10 March 2006 11:21
		Re: [PATCH] {get\|set}sockopt compatibility layer By: davem on Fri, 10 March 2006 11:34
		Re: [PATCH 1/2] iptables 32bit compat layer By: Andi Kleen on Mon, 20 February 2006 21:23
		Re: Re: [PATCH 1/2] iptables 32bit compat layer By: dim on Tue, 21 February 2006 09:24
		[PATCH] iptables 32bit compat layer By: Mishin Dmitry on Thu, 23 March 2006 10:24
		Re: [PATCH] iptables 32bit compat layer By: Patrick McHardy on Wed, 29 March 2006 09:28
		Re: [PATCH] iptables 32bit compat layer By: Mishin Dmitry on Wed, 29 March 2006 11:36
		Re: [PATCH] iptables 32bit compat layer By: Patrick McHardy on Wed, 29 March 2006 12:32
		Re: [PATCH] iptables 32bit compat layer By: Mishin Dmitry on Wed, 29 March 2006 12:38
		Re: [PATCH] iptables 32bit compat layer By: Patrick McHardy on Wed, 29 March 2006 12:47
		Re: [PATCH] iptables 32bit compat layer By: davem on Wed, 29 March 2006 21:53
		Re: [PATCH] iptables 32bit compat layer By: Patrick McHardy on Wed, 29 March 2006 23:01

Previous Topic:	[RFC] Virtualization patches for IPC/UTS. 2nd step
Next Topic:	Re: Linux-VServer and OpenVZ for Debian

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Wed Dec 03 07:42:10 GMT 2025

Total time taken to generate the page: 0.61997 seconds