OpenVZ Forum: Devel » [PATCH] Fix leaks on /proc/{*/sched, sched_debug, timer_list, timer

Home » Mailing lists » Devel » [PATCH] Fix leaks on /proc/{*/sched, sched_debug, timer_list, timer_stats}

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH] Fix leaks on /proc/{*/sched,sched_debug,timer_list,timer_stats} [message #15037 is a reply to message #15036]

Tue, 17 July 2007 12:36

Ingo Molnar
Messages: 51
Registered: December 2005

Member

* Alexey Dobriyan <adobriyan@sw.ru> wrote:

> On every open/close one struct seq_operations leaks.
> Kudos to /proc/slab_allocators.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>

ouch ...

Acked-by: Ingo Molnar <mingo@elte.hu>

-stable material too, as far as timer_info/stats goes.

> - .release = seq_release,
> + .release = single_release,

i think seq_release() definitely needs to grow a WARN_ON() if it's being
used on an inode that was opened via single_open(). This bug is so
easily committed, and nothing but a small leak reminds us on it.

Ingo

Report message to a moderator

[Message index]

		[PATCH] Fix leaks on /proc/{*/sched, sched_debug, timer_list, timer_stats} By: Alexey Dobriyan on Tue, 17 July 2007 12:25
		Re: [PATCH] Fix leaks on /proc/{*/sched,sched_debug,timer_list,timer_stats} By: Ingo Molnar on Tue, 17 July 2007 12:36
		[PATCH] Fix leak on /proc/lockdep_stats By: Alexey Dobriyan on Tue, 17 July 2007 12:57
		Re: [PATCH] Fix leaks on /proc/{*/sched,sched_debug,timer_list,timer_stats} By: Andrew Morton on Wed, 18 July 2007 00:53
		Re: [PATCH] Fix leaks on /proc/{*/sched,sched_debug,timer_list,timer_stats} By: Chris Wright on Wed, 18 July 2007 01:28

Previous Topic:	[PATCH 1/1] user namespace: fix copy_user_ns return value
Next Topic:	user namespace - introduction

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Tue Oct 15 01:03:24 GMT 2024

Total time taken to generate the page: 0.06804 seconds