OpenVZ Forum: Devel » [PATCH] Fix user struct leakage with locked IPC shem segment

Home » Mailing lists » Devel » [PATCH] Fix user struct leakage with locked IPC shem segment

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: Re: [PATCH] Fix user struct leakage with locked IPC shem segment [message #15024 is a reply to message #15014]

Tue, 17 July 2007 09:06

dev
Messages: 1693
Registered: September 2005
Location: Moscow

Senior Member

Andrew Morton wrote:
> On Mon, 16 Jul 2007 16:24:12 +0400
> Pavel Emelianov <xemul@openvz.org> wrote:
>
>
>>When user locks an ipc shmem segmant with SHM_LOCK ctl and the
>>segment is already locked the shmem_lock() function returns 0.
>>After this the subsequent code leaks the existing user struct:
>
>
> I'm curious. For the past few months, people@openvz.org have discovered
> (and fixed) an ongoing stream of obscure but serious and quite
> long-standing bugs.

thanks a lot :@)

> How are you discovering these bugs?

Not sure what to answer :) Just trying to do our best.

This bug was thought over by Pavel for about 3 month after a single
uid leak in container was detected by beancounters' kernel memory accounting...

>>== ipc/shm.c: sys_shmctl() ==
>> ...
>> err = shmem_lock(shp->shm_file, 1, user);
>> if (!err) {
>> shp->shm_perm.mode |= SHM_LOCKED;
>> shp->mlock_user = user;
>> }
>> ...
>>==
>>
>>Other results of this are:
>>1. the new shp->mlock_user is not get-ed and will point to freed
>> memory when the task dies.
>
>
> That sounds fairly serious - can this lead to memory corruption and crashes?

Yes it can. According to Pavel when the shmem segment is destroyed it
puts the mlock_user pointer, which can already be stalled.

Kirill

Report message to a moderator

[Message index]

		[PATCH] Fix user struct leakage with locked IPC shem segment By: Pavel Emelianov on Mon, 16 July 2007 12:24
		Re: [PATCH] Fix user struct leakage with locked IPC shem segment By: Andrew Morton on Mon, 16 July 2007 22:17
		Re: Re: [PATCH] Fix user struct leakage with locked IPC shem segment By: dev on Tue, 17 July 2007 09:06
		Re: Re: [PATCH] Fix user struct leakage with locked IPC shem segment By: Andrew Morton on Tue, 17 July 2007 09:15

Previous Topic:	Re: Containers: css_put() dilemma
Next Topic:	Re: Containers: css_put() dilemma

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Tue Sep 09 11:40:41 GMT 2025

Total time taken to generate the page: 0.07749 seconds