OpenVZ Forum: Devel » [PATCH 1/2] containers: implement subsys->post

Home » Mailing lists » Devel » [PATCH 1/2] containers: implement subsys->post_clone()

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH 2/2] containers: implement namespace tracking subsystem (v3) [message #14378 is a reply to message #14065]

Tue, 26 June 2007 21:58

Andrew Morton
Messages: 127
Registered: December 2005

Senior Member

On Wed, 13 Jun 2007 18:01:25 -0500
"Serge E. Hallyn" <serue@us.ibm.com> wrote:

> @@ -177,6 +184,15 @@ int unshare_nsproxy_namespaces(unsigned long unshare_flags,
> if (IS_ERR(*new_nsp)) {
> err = PTR_ERR(*new_nsp);
> put_nsproxy(old_ns);
> + goto out;
> + }
> +
> + err = ns_container_clone(current);
> + if (err) {
> + put_nsproxy(*new_nsp);
> + put_nsproxy(old_ns);
> }
> +
> +out:
> return err;
> }

I had to fix a reject here: the put_nsproxy(old_ns) has disappeared from
this code.

end result:

int unshare_nsproxy_namespaces(unsigned long unshare_flags,
struct nsproxy **new_nsp, struct fs_struct *new_fs)
{
int err = 0;

if (!(unshare_flags & (CLONE_NEWNS | CLONE_NEWUTS | CLONE_NEWIPC |
CLONE_NEWUSER)))
return 0;

if (!capable(CAP_SYS_ADMIN))
return -EPERM;

*new_nsp = create_new_namespaces(unshare_flags, current,
new_fs ? new_fs : current->fs);
if (IS_ERR(*new_nsp))
err = PTR_ERR(*new_nsp);
goto out;
}

err = ns_container_clone(current);
if (err)
put_nsproxy(*new_nsp);

out:
return err;
}

Report message to a moderator

[Message index]

		[PATCH 1/2] containers: implement subsys->post_clone() By: serue on Wed, 13 June 2007 22:56
		[PATCH 2/2] containers: implement namespace tracking subsystem (v3) By: serue on Wed, 13 June 2007 23:01
		Re: [PATCH 2/2] containers: implement namespace tracking subsystem (v3) By: Andrew Morton on Tue, 26 June 2007 21:58
		Re: [PATCH 2/2] containers: implement namespace tracking subsystem (v3) By: serue on Tue, 26 June 2007 22:51
		Re: [PATCH 1/2] containers: implement subsys->post_clone() By: Paul Jackson on Wed, 13 June 2007 23:08

Previous Topic:	sysfs entries inside VE
Next Topic:	[PATCH 0/28] Pid namespaces (two models)

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sun Jun 14 20:51:33 GMT 2026

Total time taken to generate the page: 0.43679 seconds