OpenVZ Forum: Devel » [PATCH][RFC] Cleanup in namespaces unsharing

Home » Mailing lists » Devel » [PATCH][RFC] Cleanup in namespaces unsharing

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH][RFC] Cleanup in namespaces unsharing [message #13953 is a reply to message #13948]

Fri, 08 June 2007 12:01

Cedric Le Goater
Messages: 443
Registered: February 2006

Senior Member

Pavel Emelianov wrote:
> Cedric Le Goater wrote:
>> Pavel Emelianov wrote:
>>> Currently we have two funtions to copy the namespaces:
>>> copy_namespaces() and unshare_nsproxy_namespaces(). The
>>> second one checks for unsupported functionality with
>>>
>>> #ifndef CONFIG_IPC_NS
>>> if (unshare_flags & CLONE_NEWIPC)
>>> return -EINVAL;
>>> #endif
>>>
>>> -like constructions, while the first one does not. One
>>> of the side effects of this is that clone() with the
>>> CLONE_NEWXXX set will return 0 if the kernel doesn't
>>> support XXX namespaces thus confusing the user-level.
>>>
>>> The proposal is to make these calls clean from the ifdefs
>>> and move these checks into each namespaces' stubs. This
>>> will make the code cleaner and (!) return -EINVAL from
>>> fork() in case the desired namespaces are not supported.
>>>
>>> Did I miss something in the design or this patch worth merging?
>> I've sent a more brutal patch in the past removing CONFIG_IPC_NS
>> and CONFIG_UTS_NS. Might be a better idea ?
>
> In case namespaces do not produce performance loss - yes.
>
> By that patch I also wanted to note that we'd better make
> all the other namespaces check for flags themselves, not
> putting this in the generic code.

yep. let's fix that in the coming ones if they have config option.

a similar issue is the following check done in
unshare_nsproxy_namespaces() and copy_namespaces() :

if (!capable(CAP_SYS_ADMIN))
return -EPERM;

it would be interesting to let the namespace handle the unshare
permissions. CAP_SYS_ADMIN shouldn't be required for all namespaces.
ipc is one example.

C.

Report message to a moderator

[Message index]

		[PATCH][RFC] Cleanup in namespaces unsharing By: Pavel Emelianov on Fri, 08 June 2007 09:09
		Re: [PATCH][RFC] Cleanup in namespaces unsharing By: Cedric Le Goater on Fri, 08 June 2007 09:35
		Re: [PATCH][RFC] Cleanup in namespaces unsharing By: Pavel Emelianov on Fri, 08 June 2007 11:23
		Re: [PATCH][RFC] Cleanup in namespaces unsharing By: Cedric Le Goater on Fri, 08 June 2007 12:01
		Re: [PATCH][RFC] Cleanup in namespaces unsharing By: Pavel Emelianov on Fri, 08 June 2007 13:01
		Re: [PATCH][RFC] Cleanup in namespaces unsharing By: serue on Fri, 08 June 2007 14:07

Previous Topic:	[PATCH -mm] remove CONFIG_UTS_NS and CONFIG_IPC_NS
Next Topic:	[PATCH -mm 2/2] user namespace : add unshare

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Mon Sep 01 05:32:36 GMT 2025

Total time taken to generate the page: 0.06077 seconds