OpenVZ Forum


Home » Mailing lists » Devel » [RFC PATCH ext3/ext4] orphan list corruption due bad inode
Re: [RFC PATCH ext3/ext4] orphan list corruption due bad inode [message #13774 is a reply to message #13771] Tue, 05 June 2007 06:11 Go to previous messageGo to previous message
vaverin is currently offline  vaverin
Messages: 708
Registered: September 2005
Senior Member
Andrew Morton wrote:
> On Mon, 04 Jun 2007 09:19:10 +0400 Vasily Averin <vvs@sw.ru> wrote:
>> diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c
>> index 9bb046d..e3ac8c3 100644
>> --- a/fs/ext3/namei.c
>> +++ b/fs/ext3/namei.c
>> @@ -1019,6 +1019,11 @@ static struct dentry *ext3_lookup(struct inode * dir, struct dentry *dentry, str
>>
>> if (!inode)
>> return ERR_PTR(-EACCES);
>> +
>> + if (is_bad_inode(inode)) {
>> + iput(inode);
>> + return ERR_PTR(-ENOENT);
>> + }
>> }
>> return d_splice_alias(inode, dentry);
>> }
> Seems reasonable. So this prevents the bad inodes from getting onto the
> orphan list in the first place?

make_bad_inode() is called from ext3_read_inode() that is called from iget() only.

When we found that inode is bad we will call iput ASAP. I expect it should be
enough to exclude any chances to call any functions that can include this inode
into orphan list.

ext3_lookup
iget
ext3_read_inode
make_bad_inode
is_bad_inode? --> iput

However am I probably err?

Probably is better to add is_bad_inode check to ext3_orphan_add()?

thank you,
Vasily Averin

Report message to a moderator

[Message index]
 
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Previous Topic: Re: [Fwd: [PATCH -RSS 2/2] Fix limit check after reclaim]
Next Topic: Re: [Fwd: [PATCH -RSS 2/2] Fix limit check after reclaim]
Goto Forum:
  

[ Syndicate this forum (XML) ] [ RSS ] [ PDF ]

Current Time: Mon Dec 08 00:16:36 GMT 2025

Total time taken to generate the page: 0.08149 seconds
Powered by FUDforum Powered by Virtuozzo Containers