OpenVZ Forum: Devel » [PATCH 0/13] Pid namespaces (OpenVZ view)

Home » Mailing lists » Devel » [PATCH 0/13] Pid namespaces (OpenVZ view)

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH 1/13] Round up the API [message #13332 is a reply to message #13325]

Thu, 24 May 2007 16:48

serue
Messages: 750
Registered: February 2006

Senior Member

Quoting Eric W. Biederman (ebiederm@xmission.com):
> "Serge E. Hallyn" <serue@us.ibm.com> writes:
>
> > Quoting Pavel Emelianov (xemul@openvz.org):
> >> The set of functions process_session, task_session, process_group
> >> and task_pgrp is confusing, as the names can be mixed with each other
> >> when looking at the code for a long time.
> >>
> >> The proposals are to
> >> * equip the functions that return the integer with _nr suffix to
> >> represent that fact,
> >> * and to make all functions work with task (not process) by making
> >> the common prefix of the same name.
> >>
> >> For monotony the routines signal_session() and set_signal_session()
> >> are replaced with task_session_nr() and set_task_session(), especially
> >> since they are only used with the explicit task->signal dereference.
> >>
> >> I've sent this before, but Andrew didn't include it, so I resend it
> >> as the part of this set.
> >>
> >> Signed-off-by: Pavel Emelianov <xemul@openvz.org>
> >> Acked-by: Serge E. Hallyn <serue@us.ibm.com>
> >
> > Yup, I still like this patch.
>
> I'm borderline. Less error prone interfaces sound good, less
> duplication of information sounds good. Changing the names of
> historical function may be change for the sake of change and
> thus noise.
>
> However if we are going to go this far I think we need to remove
> the numeric pid cache from the task_struct.

You mean tsk->pid?

I agree, especially in Suka's version. Not sure it applies to Pavel's
version, though since the "real"/global pid is still stored only in
tsk->pid, right?

-serge

Report message to a moderator

[Message index]

		[PATCH 0/13] Pid namespaces (OpenVZ view) By: Pavel Emelianov on Thu, 24 May 2007 12:32
		[PATCH 1/13] Round up the API By: Pavel Emelianov on Thu, 24 May 2007 12:35
		Re: [PATCH 1/13] Round up the API By: serue on Thu, 24 May 2007 16:09
		Re: [PATCH 1/13] Round up the API By: ebiederm on Thu, 24 May 2007 16:22
		Re: [PATCH 1/13] Round up the API By: Pavel Emelianov on Thu, 24 May 2007 16:31
		Re: [PATCH 1/13] Round up the API By: serue on Thu, 24 May 2007 16:48
		Re: [PATCH 1/13] Round up the API By: Pavel Emelianov on Fri, 25 May 2007 07:00
		Re: [PATCH 1/13] Round up the API By: serue on Fri, 25 May 2007 13:02
		[PATCH 2/13] Small preparations for namespaces By: Pavel Emelianov on Thu, 24 May 2007 12:37
		Re: [PATCH 2/13] Small preparations for namespaces By: serue on Thu, 24 May 2007 16:08
		Re: [PATCH 2/13] Small preparations for namespaces By: Pavel Emelianov on Fri, 25 May 2007 06:58
		Re: [PATCH 2/13] Small preparations for namespaces By: serue on Fri, 25 May 2007 13:01
		Re: [PATCH 2/13] Small preparations for namespaces By: Pavel Emelianov on Fri, 25 May 2007 13:21
		Re: [PATCH 2/13] Small preparations for namespaces By: serue on Fri, 25 May 2007 13:55
		[PATCH 3/13] Introduciton of config option and clone flag By: Pavel Emelianov on Thu, 24 May 2007 12:42
		Re: [PATCH 3/13] Introduciton of config option and clone flag By: ebiederm on Thu, 24 May 2007 15:39
		[PATCH 4/13] Introduce the vpid fields and helpers for getting them By: Pavel Emelianov on Thu, 24 May 2007 12:44
		[PATCH 5/13] Expand the pid/task seeking functions set By: Pavel Emelianov on Thu, 24 May 2007 12:46
		Re: [PATCH 5/13] Expand the pid/task seeking functions set By: Dave Hansen on Thu, 24 May 2007 17:11
		Re: [PATCH 5/13] Expand the pid/task seeking functions set By: Pavel Emelianov on Fri, 25 May 2007 07:08
		Re: [PATCH 5/13] Expand the pid/task seeking functions set By: Sukadev Bhattiprolu on Fri, 25 May 2007 23:36
		[PATCH 6/13] Pid allocation/freeing procedures By: Pavel Emelianov on Thu, 24 May 2007 12:49
		[PATCH 7/13] Set virtual pids for a newly cloned task By: Pavel Emelianov on Thu, 24 May 2007 12:53
		[PATCH 8/13] The namespace cloning By: Pavel Emelianov on Thu, 24 May 2007 12:57
		[PATCH 9/13] Make proc be able to have multiple super blocks By: Pavel Emelianov on Thu, 24 May 2007 13:01
		[PATCH 10/13] Make proc draw pids from appropriate namespace By: Pavel Emelianov on Thu, 24 May 2007 13:04
		[PATCH 11/13] Changes to show virtual ids to user By: Pavel Emelianov on Thu, 24 May 2007 13:06
		Re: [PATCH 11/13] Changes to show virtual ids to user By: ebiederm on Thu, 24 May 2007 16:05
		Re: [PATCH 11/13] Changes to show virtual ids to user By: xemul on Thu, 24 May 2007 16:15
		Re: [PATCH 11/13] Changes to show virtual ids to user By: ebiederm on Thu, 24 May 2007 16:33
		Re: [PATCH 11/13] Changes to show virtual ids to user By: Pavel Emelianov on Fri, 25 May 2007 06:33
		Re: [PATCH 11/13] Changes to show virtual ids to user By: ebiederm on Fri, 25 May 2007 15:48
		Re: [PATCH 11/13] Changes to show virtual ids to user By: Cedric Le Goater on Tue, 29 May 2007 12:32
		Re: [PATCH 11/13] Changes to show virtual ids to user By: Pavel Emelianov on Thu, 31 May 2007 07:57
		Re: [PATCH 11/13] Changes to show virtual ids to user By: Pavel Emelianov on Thu, 31 May 2007 08:00
		Re: [PATCH 11/13] Changes to show virtual ids to user By: ebiederm on Thu, 31 May 2007 11:26
		Re: [PATCH 11/13] Changes to show virtual ids to user By: Pavel Emelianov on Thu, 31 May 2007 11:46
		Re: [PATCH 11/13] Changes to show virtual ids to user By: ebiederm on Thu, 31 May 2007 13:41
		[PATCH 12/13] Show appropriate pids in proc By: Pavel Emelianov on Thu, 24 May 2007 13:08
		[PATCH 13/13] Make all proc entres accessible in a namespace By: Pavel Emelianov on Thu, 24 May 2007 13:13
		Instructions of how to make testing easy By: Pavel Emelianov on Thu, 24 May 2007 13:19
		Re: Instructions of how to make testing easy By: Pavel Emelianov on Thu, 24 May 2007 16:16
		Re: Instructions of how to make testing easy By: Cedric Le Goater on Thu, 24 May 2007 14:55
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: serue on Thu, 24 May 2007 15:09
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: xemul on Thu, 24 May 2007 16:11
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: serue on Thu, 24 May 2007 16:59
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: ebiederm on Thu, 24 May 2007 18:56
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: serue on Thu, 24 May 2007 19:10
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: Pavel Emelianov on Fri, 25 May 2007 07:08
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: serue on Fri, 25 May 2007 13:25
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: Pavel Emelianov on Fri, 25 May 2007 13:53
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: serue on Fri, 25 May 2007 14:25
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: Pavel Emelianov on Mon, 28 May 2007 07:48
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: ebiederm on Tue, 29 May 2007 04:30
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: Pavel Emelianov on Tue, 29 May 2007 07:47
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: ebiederm on Tue, 29 May 2007 12:36
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: Pavel Emelianov on Fri, 25 May 2007 07:06
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: ebiederm on Fri, 25 May 2007 14:55
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: ebiederm on Thu, 24 May 2007 16:00
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: serue on Thu, 24 May 2007 16:20
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: Pavel Emelianov on Fri, 25 May 2007 06:29
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: serue on Fri, 25 May 2007 13:29
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: Pavel Emelianov on Thu, 24 May 2007 16:26
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: ebiederm on Thu, 24 May 2007 19:18
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: Pavel Emelianov on Fri, 25 May 2007 07:15
		Re: Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: dev on Mon, 28 May 2007 11:50
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: ebiederm on Tue, 29 May 2007 13:07
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: Daniel Lezcano on Thu, 24 May 2007 16:41
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: Pavel Emelianov on Fri, 25 May 2007 07:26
		Re: [PATCH 0/13] Pid namespaces (OpenVZ view) By: Daniel Lezcano on Fri, 25 May 2007 08:30

Previous Topic:	Re: [ckrm-tech] [RFC] [PATCH 0/3] Add group fairness to CFS
Next Topic:	[RFC][PATCH 0/16] Enable cloning of pid namespace

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Wed Jul 30 09:20:51 GMT 2025

Total time taken to generate the page: 0.08511 seconds