OpenVZ Forum: Devel » [PATCH] Make common helpers for seq_files that work with list

Home » Mailing lists » Devel » [PATCH] Make common helpers for seq_files that work with list_head-s

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH] Make common helpers for seq_files that work with list_head-s [message #13021 is a reply to message #13017]

Thu, 17 May 2007 17:36

Andrew Morton
Messages: 127
Registered: December 2005

Senior Member

On Thu, 17 May 2007 19:19:40 +0400 Pavel Emelianov <xemul@sw.ru> wrote:

> Many places in kernel use seq_file API to iterate over a regular
> list_head. The code for such iteration is identical in all the
> places, so it's worth introducing a common helpers.
>
> This makes code more than 300 lines smaller.
>
> Cc-ed are people, who maintain the code altered by the patch.
>
> Signed-off-by: Pavel Emelianov <xemul@openvz.org>
>
> block/genhd.c | 40 +++-----
> crypto/proc.c | 17 ---
> drivers/char/misc.c | 18 ----
> drivers/input/input.c | 29 ------
> drivers/isdn/capi/kcapi_proc.c | 28 ------
> fs/afs/proc.c | 81 ++----------------
> fs/namespace.c | 14 ---
> fs/nfs/client.c | 54 +-----------
> fs/proc/proc_tty.c | 15 ---
> include/linux/seq_file.h | 35 +++++++
> kernel/module.c | 17 ---
> mm/slab.c | 28 +-----
> net/atm/br2684.c | 22 ----
> net/core/sock.c | 39 --------
> net/ipv4/netfilter/nf_conntrack_l3proto_ipv4_compat.c | 27 ------
> net/netfilter/nf_conntrack_expect.c | 27 ------
> net/rxrpc/ar-proc.c | 48 +---------
> 17 files changed, 116 insertions(+), 423 deletions(-)

Can't complain about the diffstat. Please experiment with uninlining
seq_list_start(), see if that reduces overall text size.

And as Dmitry indicated, it would be less disruptive if we could have the
one core patch then a stream of per-subsystem patches, please.

Report message to a moderator

[Message index]

		[PATCH] Make common helpers for seq_files that work with list_head-s By: xemul on Thu, 17 May 2007 15:15
		Re: [PATCH] Make common helpers for seq_files that work with list_head-s By: Andrew Morton on Thu, 17 May 2007 17:36
		Re: [PATCH] Make common helpers for seq_files that work with list_head-s By: Dmitry Torokhov on Thu, 17 May 2007 15:35

Previous Topic:	Remaining straight forward kthread API conversions...
Next Topic:	[PATCH 0/15] Make common helpers for seq_files that work with list_head-s (v2)

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sun Dec 21 10:32:16 GMT 2025

Total time taken to generate the page: 0.15772 seconds