OpenVZ Forum: Devel » [patch i2o] i2o layer cleanup

Home » Mailing lists » Devel » [patch i2o] i2o layer cleanup

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [patch i2o 5/6] i2o_proc files permission [message #12979 is a reply to message #12960]

Wed, 16 May 2007 12:49

Alan Cox
Messages: 48
Registered: May 2006

Member

> We have i2o on one of our testnodes: Adaptec Zero channel RAID 2010S integrated
> on MSI MS-9136 motherboard and I don't have access to another i2o hardware.
> Also I don't have any ideas how to detect buggy i2o node. As far as I understand
> Markus is right, and i2o hardware couldn't handle received message that on the
> first glance looks correctly.
> >From my POV it is bug in firmware and only vendor is able to fix it correctly.
> My patch is not a fix but workaround only -- it just do not allow to crash the
> node by any user in case when node admin due some reasons has loaded i2o_proc
> module.

It merely allows it to occur by accident if root does something like find
in the wrong place and it also breaks the expected behaviour for existing
systems.

There are two ways you can identify a specific controller if the vendor
didn't totally screw up

The first is the PCI idents or subidents, the second is to look at the
tables returned when the controller is being set up. In fact the
Adaptecrap controllers (ex DPT) are already detected and we set
c->adaptec in pci.c so we can stop them exploding for other reasons and
to use some extensions they have.

Thus I think the right solution is to skip registering those proc files
(and unregistering them on unload) if c->adaptec is set.

Report message to a moderator

[Message index]

		[patch i2o] i2o layer cleanup By: vaverin on Tue, 15 May 2007 12:41
		[patch i2o 1/6] i2o_cfg_passthru cleanup By: vaverin on Tue, 15 May 2007 12:42
		Re: [patch i2o 1/6] i2o_cfg_passthru cleanup By: Alan Cox on Tue, 15 May 2007 16:42
		[patch i2o 2/6] wrong memory access in i2o_block_device_lock() By: vaverin on Tue, 15 May 2007 12:43
		[patch i2o 3/6] i2o message leak in i2o_msg_post_wait_mem() By: vaverin on Tue, 15 May 2007 12:44
		[patch i2o 4/6] i2o proc reading oops By: vaverin on Tue, 15 May 2007 12:45
		[patch i2o 5/6] i2o_proc files permission By: vaverin on Tue, 15 May 2007 12:47
		Re: [patch i2o 5/6] i2o_proc files permission By: vaverin on Tue, 15 May 2007 12:59
		Re: [patch i2o 5/6] i2o_proc files permission By: Greg KH on Wed, 16 May 2007 09:27
		Re: [patch i2o 5/6] i2o_proc files permission By: Alan Cox on Tue, 15 May 2007 16:45
		Re: [patch i2o 5/6] i2o_proc files permission By: vaverin on Wed, 16 May 2007 04:58
		Re: [patch i2o 5/6] i2o_proc files permission By: Alan Cox on Wed, 16 May 2007 12:49
		[patch i2o 6/6] i2o debug output cleanup By: vaverin on Tue, 15 May 2007 12:48
		Re: [patch i2o 6/6] i2o debug output cleanup By: Alan Cox on Tue, 15 May 2007 16:46
		Re: [patch i2o] i2o layer cleanup By: Kirill Korotaev on Tue, 15 May 2007 12:53

Previous Topic:	[PATCH] Brush up task's session and group numbers manipulations
Next Topic:	Remaining straight forward kthread API conversions...

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sat Aug 02 14:00:51 GMT 2025

Total time taken to generate the page: 0.93890 seconds