OpenVZ Forum: Devel » [patch i2o] i2o layer cleanup

Home » Mailing lists » Devel » [patch i2o] i2o layer cleanup

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

[patch i2o 2/6] wrong memory access in i2o_block_device_lock() [message #12937 is a reply to message #12935]

Tue, 15 May 2007 12:43

vaverin
Messages: 708
Registered: September 2005

Senior Member

This patch fixes access to memory that has not been allocated:
i2o_msg_get_wait() can returns errors different from I2O_QUEUE_EMPTY. But the
result is checked only against this code. If it is not I2O_QUEUE_EMPTY then we
dereference the error code as the pointer later.

Signed-off-by: Vasily Averin <vvs@sw.ru>

--- lk2.6/drivers/message/i2o/i2o_block.c
+++ lk2.6/drivers/message/i2o/i2o_block.c
@@ -215,7 +215,7 @@ static int i2o_block_device_lock(struct
struct i2o_message *msg;

msg = i2o_msg_get_wait(dev->iop, I2O_TIMEOUT_MESSAGE_GET);
- if (IS_ERR(msg) == I2O_QUEUE_EMPTY)
+ if (IS_ERR(msg))
return PTR_ERR(msg);

msg->u.head[0] = cpu_to_le32(FIVE_WORD_MSG_SIZE | SGL_OFFSET_0);

Report message to a moderator

[Message index]

		[patch i2o] i2o layer cleanup By: vaverin on Tue, 15 May 2007 12:41
		[patch i2o 1/6] i2o_cfg_passthru cleanup By: vaverin on Tue, 15 May 2007 12:42
		Re: [patch i2o 1/6] i2o_cfg_passthru cleanup By: Alan Cox on Tue, 15 May 2007 16:42
		[patch i2o 2/6] wrong memory access in i2o_block_device_lock() By: vaverin on Tue, 15 May 2007 12:43
		[patch i2o 3/6] i2o message leak in i2o_msg_post_wait_mem() By: vaverin on Tue, 15 May 2007 12:44
		[patch i2o 4/6] i2o proc reading oops By: vaverin on Tue, 15 May 2007 12:45
		[patch i2o 5/6] i2o_proc files permission By: vaverin on Tue, 15 May 2007 12:47
		Re: [patch i2o 5/6] i2o_proc files permission By: vaverin on Tue, 15 May 2007 12:59
		Re: [patch i2o 5/6] i2o_proc files permission By: Greg KH on Wed, 16 May 2007 09:27
		Re: [patch i2o 5/6] i2o_proc files permission By: Alan Cox on Tue, 15 May 2007 16:45
		Re: [patch i2o 5/6] i2o_proc files permission By: vaverin on Wed, 16 May 2007 04:58
		Re: [patch i2o 5/6] i2o_proc files permission By: Alan Cox on Wed, 16 May 2007 12:49
		[patch i2o 6/6] i2o debug output cleanup By: vaverin on Tue, 15 May 2007 12:48
		Re: [patch i2o 6/6] i2o debug output cleanup By: Alan Cox on Tue, 15 May 2007 16:46
		Re: [patch i2o] i2o layer cleanup By: Kirill Korotaev on Tue, 15 May 2007 12:53

Previous Topic:	[PATCH] Brush up task's session and group numbers manipulations
Next Topic:	Remaining straight forward kthread API conversions...

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Thu Nov 06 01:13:32 GMT 2025

Total time taken to generate the page: 0.08904 seconds