OpenVZ Forum: Devel » [RFC][PATCH 1/5] Virtualization/containers: startup

Home » Mailing lists » Devel » [RFC][PATCH 1/5] Virtualization/containers: startup

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [RFC][PATCH 3/5] Virtualization/containers: UTSNAME [message #1293 is a reply to message #1290]

Mon, 06 February 2006 08:51

dev
Messages: 1693
Registered: September 2005
Location: Moscow

Senior Member

> I am disturbed by the introduction of #defines like current_vps() and
> vps_utsname.
>
> Magic lower case #defines are usually a bad idea.
It is not magic defines, this is done intentionally.
You can take a more detailed view into OpenVZ sources, but the idea is
to make kernel compilable without virtualization.
When virtualization is OFF all this macros are defined to trivial
variables/defines which make it an old good kernel.

For example current_vps() should be (&init_vps), i.e. host system
environment only.

vps_utsname will be defined as system_utsname and so on.

> These defines hide the cost of the operations you are performing.
> At that point you might as well name the thing system_utsname
> so you don't have to change the code.
You mean to have variable and define with the same names?
it is not always good. It works fine, when both are defined in the same
file, but poorly when it is scattered all around...

> And of course you failed to change several references to
> system_utsname.
which one? Maybe intentionally? ;-)
Kirill

Report message to a moderator

[Message index]

		[RFC][PATCH 1/5] Virtualization/containers: startup By: Kirill Korotaev on Fri, 03 February 2006 16:57
		[RFC][PATCH 2/5] Virtualization/containers: UIDs By: dev on Fri, 03 February 2006 17:01
		[RFC][PATCH 3/5] Virtualization/containers: UTSNAME By: dev on Fri, 03 February 2006 17:04
		Re: [RFC][PATCH 3/5] Virtualization/containers: UTSNAME By: ebiederm on Mon, 06 February 2006 08:21
		Re: [RFC][PATCH 3/5] Virtualization/containers: UTSNAME By: dev on Mon, 06 February 2006 08:51
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Fri, 03 February 2006 17:22
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Linus Torvalds on Fri, 03 February 2006 17:49
		Summary: PID virtualization , Containers, Migration By: Hubertus Franke on Fri, 03 February 2006 18:36
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Rik van Riel on Fri, 03 February 2006 18:36
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Sun, 05 February 2006 14:52
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: ebiederm on Mon, 06 February 2006 08:39
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Mon, 06 February 2006 08:58
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: ebiederm on Mon, 06 February 2006 09:19
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Dave Hansen on Mon, 06 February 2006 16:37
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: ebiederm on Mon, 06 February 2006 18:37
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Mon, 06 February 2006 19:30
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Cedric Le Goater on Mon, 06 February 2006 22:40
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: ebiederm on Tue, 07 February 2006 01:57
		swsusp done by migration (was Re: [RFC][PATCH 1/5] Virtualization/containers: startup) By: Pavel Machek on Wed, 08 February 2006 21:54
		Re: swsusp done by migration (was Re: [RFC][PATCH 1/5] Virtualization/containers: startup) By: ebiederm on Thu, 09 February 2006 18:20
		Re: swsusp done by migration (was Re: [RFC][PATCH 1/5] Virtualization/containers: startup) By: Kyle Moffett on Fri, 10 February 2006 00:21
		Re: swsusp done by migration (was Re: [RFC][PATCH 1/5] Virtualization/containers: startup) By: Sam Vilain on Fri, 10 February 2006 04:31
		Re: Re: swsusp done by migration (was Re: [RFC][PATCH 1/5] Virtualization/containers: startup) By: vaverin on Fri, 10 February 2006 06:23
		Re: Re: swsusp done by migration (was Re: [RFC][PATCH 1/5] Virtualization/containers: startup) By: Sam Vilain on Sat, 11 February 2006 02:38
		Re: Re: swsusp done by migration (was Re: [RFC][PATCH 1/5] Virtualization/containers: startup) By: vaverin on Sat, 11 February 2006 17:29
		Re: swsusp done by migration (was Re: [RFC][PATCH 1/5] Virtualization/containers: startup) By: Kyle Moffett on Fri, 10 February 2006 08:29
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Nigel Cunningham on Fri, 10 February 2006 05:40
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Dave Hansen on Fri, 03 February 2006 18:34
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Jeff Garzik on Fri, 03 February 2006 18:55
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Hubertus Franke on Fri, 03 February 2006 19:18
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Hubertus Franke on Fri, 03 February 2006 19:56
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Greg KH on Fri, 03 February 2006 20:19
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Sun, 05 February 2006 15:10
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Sun, 05 February 2006 15:05
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Dave Hansen on Mon, 06 February 2006 16:35
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Mon, 06 February 2006 16:50
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Linus Torvalds on Mon, 06 February 2006 16:56
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Mon, 06 February 2006 17:19
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Sam Vilain on Tue, 07 February 2006 00:28
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Tue, 07 February 2006 12:19
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Sam Vilain on Tue, 07 February 2006 22:21
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Mon, 20 February 2006 11:54
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Linus Torvalds on Fri, 03 February 2006 17:15
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Hubertus Franke on Fri, 03 February 2006 20:34
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Sun, 05 February 2006 15:11
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Hubertus Franke on Sun, 05 February 2006 15:39
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Mon, 06 February 2006 09:06
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Cedric Le Goater on Mon, 06 February 2006 22:31
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Tue, 07 February 2006 12:25
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: Benjamin Herrenschmid on Mon, 06 February 2006 00:56
		Re: Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: dev on Mon, 06 February 2006 09:01
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: ebiederm on Mon, 06 February 2006 08:31
		Re: [RFC][PATCH 1/5] Virtualization/containers: startup By: ebiederm on Fri, 10 February 2006 06:01

Previous Topic:	Versioning issue on vzquota-3.0.0-2
Next Topic:	Versioning issue on vzquota-3.0.0-2

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sat Aug 09 19:25:49 GMT 2025

Total time taken to generate the page: 1.19671 seconds