OpenVZ Forum: Devel » [PATCH] Check for error returned by kthread

Home » Mailing lists » Devel » [PATCH] Check for error returned by kthread_create on creating journal thread

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH] Check for error returned by kthread_create on creating journal thread [message #12220 is a reply to message #12033]

Fri, 20 April 2007 22:38

Andrew Morton
Messages: 127
Registered: December 2005

Senior Member

On Mon, 16 Apr 2007 11:41:14 +0400
Pavel Emelianov <xemul@sw.ru> wrote:

> If the thread failed to create the subsequent wait_event
> will hang forever.
>
> This is likely to happen if kernel hits max_threads limit.
>
> Will be critical for virtualization systems that limit the
> number of tasks and kernel memory usage within the container.
>
>
> [diff-jbd-check-start-journal-thread-return-value text/plain (1.7KB)]
> --- ./fs/jbd/journal.c.jbdthreads 2007-04-16 11:17:36.000000000 +0400
> +++ ./fs/jbd/journal.c 2007-04-16 11:30:09.000000000 +0400
> @@ -211,10 +211,16 @@ end_loop:
> return 0;
> }
>
> -static void journal_start_thread(journal_t *journal)
> +static int journal_start_thread(journal_t *journal)
> {
> - kthread_run(kjournald, journal, "kjournald");
> + struct task_struct *t;
> +
> + t = kthread_run(kjournald, journal, "kjournald");
> + if (IS_ERR(t))
> + return PTR_ERR(t);
> +
> wait_event(journal->j_wait_done_commit, journal->j_task != 0);
> + return 0;
> }

Thanks. Please don't forget those Signed-off-by:s

I assume that you runtime tested this and that the mount failed in
an appropriate fashion?

Report message to a moderator

[Message index]

		[PATCH] Check for error returned by kthread_create on creating journal thread By: xemul on Mon, 16 April 2007 07:40
		Re: [PATCH] Check for error returned by kthread_create on creating journal thread By: Christoph Hellwig on Mon, 16 April 2007 10:21
		Re: [PATCH] Check for error returned by kthread_create on creating journal thread By: xemul on Mon, 16 April 2007 11:07
		Re: [PATCH] Check for error returned by kthread_create on creating journal thread By: Christoph Hellwig on Mon, 16 April 2007 11:10
		Re: [PATCH] Check for error returned by kthread_create on creating journal thread By: Andrew Morton on Fri, 20 April 2007 22:38
		Re: [PATCH] Check for error returned by kthread_create on creating journal thread By: xemul on Mon, 23 April 2007 06:13

Previous Topic:	Re: Re: [PATCH] bluetooth bnep: Convert to kthread API.
Next Topic:	mailing list settings removes From: ?

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sat Aug 02 16:51:18 GMT 2025

Total time taken to generate the page: 0.43452 seconds