OpenVZ Forum: Devel » [BRIDGE] Unaligned access on IA64 when comparing ethernet addresses

Home » Mailing lists » Devel » [BRIDGE] Unaligned access on IA64 when comparing ethernet addresses

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [BRIDGE] Unaligned access on IA64 when comparing ethernet addresses [message #12166 is a reply to message #12144]

Wed, 18 April 2007 14:44

Stephen Hemminger
Messages: 37
Registered: August 2006

Member

On Wed, 18 Apr 2007 01:28:04 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:

> From: Pavel Emelianov <xemul@sw.ru>
> Date: Wed, 18 Apr 2007 10:43:56 +0400
>
> > [snip]
> >
> > > --- linux-2.6.orig/net/bridge/br_private.h 2007-04-17
> > > 13:26:48.000000000 -0700 +++ linux-2.6/net/bridge/br_private.h
> > > 2007-04-17 13:30:29.000000000 -0700 @@ -36,7 +36,7 @@
> > > {
> > > unsigned char prio[2];
> > > unsigned char addr[6];
> > > -};
> > > +} __attribute__((aligned(8)));
> >
> > Why "8"? Mustn't it be "16"? Address is to be 2-bytes aligned...
>
> Actually it could be made "2", the aligned() attribute is
> in bytes, not bits.

It could be 2 but 8 might allow a compiler on a 64 bit platform
to be smarter in comparisons and assignments. For 2.6.22, I'll make
a nicer version similar to ktime_t.

Report message to a moderator

[Message index]

		[BRIDGE] Unaligned access on IA64 when comparing ethernet addresses By: xemul on Tue, 17 April 2007 11:45
		Re: [BRIDGE] Unaligned access on IA64 when comparing ethernet addresses By: davem on Tue, 17 April 2007 19:31
		Re: [BRIDGE] Unaligned access on IA64 when comparing ethernet addresses By: Stephen Hemminger on Tue, 17 April 2007 19:55
		Re: [BRIDGE] Unaligned access on IA64 when comparing ethernet addresses By: davem on Tue, 17 April 2007 20:09
		Re: [BRIDGE] Unaligned access on IA64 when comparing ethernet addresses By: Stephen Hemminger on Tue, 17 April 2007 20:37
		Re: [BRIDGE] Unaligned access on IA64 when comparing ethernet addresses By: davem on Tue, 17 April 2007 21:09
		Re: [BRIDGE] Unaligned access on IA64 when comparing ethernet addresses By: Eric Dumazet on Tue, 17 April 2007 21:24
		Re: [BRIDGE] Unaligned access on IA64 when comparing ethernet addresses By: davem on Tue, 17 April 2007 21:27
		Re: [BRIDGE] Unaligned access on IA64 when comparing ethernet addresses By: xemul on Wed, 18 April 2007 06:39
		Re: [BRIDGE] Unaligned access on IA64 when comparing ethernet addresses By: davem on Wed, 18 April 2007 08:28
		Re: [BRIDGE] Unaligned access on IA64 when comparing ethernet addresses By: xemul on Wed, 18 April 2007 08:32
		Re: [BRIDGE] Unaligned access on IA64 when comparing ethernet addresses By: Stephen Hemminger on Wed, 18 April 2007 14:44
		Re: [BRIDGE] Unaligned access on IA64 when comparing ethernet addresses By: davem on Wed, 18 April 2007 20:04
		Re: [BRIDGE] Unaligned access on IA64 when comparing ethernet addresses By: Eric Dumazet on Thu, 19 April 2007 14:14
		Re: [BRIDGE] Unaligned access on IA64 when comparing ethernet addresses By: Stephen Hemminger on Thu, 19 April 2007 18:18
		Re: [BRIDGE] Unaligned access on IA64 when comparing ethernet addresses By: davem on Thu, 19 April 2007 20:01
		Re: [BRIDGE] Unaligned access on IA64 when comparing ethernet addresses By: Eric Dumazet on Thu, 19 April 2007 20:29

Previous Topic:	Re: Getting the new RxRPC patches upstream
Next Topic:	[PATCH] Show slab memory usage on OOM and SysRq-M (v3)

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Wed Oct 08 15:06:35 GMT 2025

Total time taken to generate the page: 0.11253 seconds