OpenVZ Forum: Devel » [NETLINK] Don't attach callback to a going-away netlink socket

Home » Mailing lists » Devel » [NETLINK] Don't attach callback to a going-away netlink socket

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [NETLINK] Don't attach callback to a going-away netlink socket [message #12153 is a reply to message #12151]

Wed, 18 April 2007 09:16

Patrick McHardy
Messages: 107
Registered: March 2006

Senior Member

Evgeniy Polyakov wrote:
> On Wed, Apr 18, 2007 at 10:50:42AM +0200, Patrick McHardy (kaber@trash.net) wrote:
>
>>>I thought that with releasing a socket, which will have a callback
>>>attached only results in a leak of the callback? In that case we can
>>>just free it in dump() just like it is done in no-error path already.
>>>Or do I miss something additional?
>>
>>That would only work if there is nothing to dump (cb->dump returns 0).
>>Otherwise it is not freed.
>
>
> That is what I referred to as error path. Btw, with positive return
> value we end up in subsequent call to input which will free callback
> under lock as expected.

No, nothing is going to call netlink_dump after the initial call since
the socket is gone.

Report message to a moderator

[Message index]

		[NETLINK] Don't attach callback to a going-away netlink socket By: xemul on Wed, 18 April 2007 08:12
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: Evgeniy Polyakov on Wed, 18 April 2007 08:17
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: Patrick McHardy on Wed, 18 April 2007 08:26
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: Evgeniy Polyakov on Wed, 18 April 2007 08:42
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: Patrick McHardy on Wed, 18 April 2007 08:50
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: Evgeniy Polyakov on Wed, 18 April 2007 09:07
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: Patrick McHardy on Wed, 18 April 2007 09:16
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: Evgeniy Polyakov on Wed, 18 April 2007 09:29
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: xemul on Wed, 18 April 2007 08:27
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: Evgeniy Polyakov on Wed, 18 April 2007 08:44
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: xemul on Wed, 18 April 2007 08:59
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: Evgeniy Polyakov on Wed, 18 April 2007 09:14
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: davem on Thu, 19 April 2007 00:06
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: Herbert Xu on Thu, 19 April 2007 02:13
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: davem on Sun, 29 April 2007 06:18
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: Herbert Xu on Wed, 02 May 2007 04:12
		Re: [NETLINK] Don't attach callback to a going-away netlink socket By: davem on Thu, 03 May 2007 10:17

Previous Topic:	[PATCH] Invalid return value of execve() resulting in oopses
Next Topic:	[PATCH] Rework dev_base via list_head (v2)

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Mon Aug 25 22:22:23 GMT 2025

Total time taken to generate the page: 0.11431 seconds