OpenVZ Forum


Home » Mailing lists » Devel » [NETLINK] Don't attach callback to a going-away netlink socket
Re: [NETLINK] Don't attach callback to a going-away netlink socket [message #12141 is a reply to message #12140] Wed, 18 April 2007 08:17 Go to previous messageGo to previous message
Evgeniy Polyakov is currently offline  Evgeniy Polyakov
Messages: 11
Registered: November 2006
Junior Member
On Wed, Apr 18, 2007 at 12:16:18PM +0400, Pavel Emelianov (xemul@sw.ru) wrote:
> Sorry, I forgot to put netdev and David in Cc when I first sent it.
>
> There is a race between netlink_dump_start() and netlink_release()
> that can lead to the situation when a netlink socket with non-zero
> callback is freed.

Out of curiosity, why not to fix a netlink_dump_start() to remove
callback in error path, since in 'no-error' path it removes it in
netlink_dump().

And, btw, can release method be called while socket is being used, I
thought about proper reference counters should prevent this, but not
100% sure with RCU dereferencing of the descriptor.

--
Evgeniy Polyakov
 
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Read Message
Previous Topic: [PATCH] Invalid return value of execve() resulting in oopses
Next Topic: [PATCH] Rework dev_base via list_head (v2)
Goto Forum:
  


Current Time: Mon Aug 25 22:21:23 GMT 2025

Total time taken to generate the page: 0.06815 seconds