OpenVZ Forum: Devel » [PATCH] Show slab memory usage on OOM and SysRq-M (v2)

Home » Mailing lists » Devel » [PATCH] Show slab memory usage on OOM and SysRq-M (v2)

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH] Show slab memory usage on OOM and SysRq-M (v2) [message #12129 is a reply to message #12101]

Wed, 18 April 2007 06:37

xemul
Messages: 248
Registered: November 2005

Senior Member

Dave Hansen wrote:
> On Tue, 2007-04-17 at 19:34 +0400, Pavel Emelianov wrote:
>> +#define SHOW_TOP_SLABS 10
>
> Real minor nit on this one: SHOW_TOP_SLABS sounds like a bool. "Should
> I show the top slabs?"
>
> This might be a bit more clear:
>
> #define TOP_NR_SLABS_TO_SHOW 10
>
> or
>
> #define NR_SLABS_TO_SHOW 10

Agree :) Will fix in a moment.

>
> -- Dave
>
>

Report message to a moderator

[Message index]

		[PATCH] Show slab memory usage on OOM and SysRq-M (v2) By: xemul on Tue, 17 April 2007 15:29
		Re: [PATCH] Show slab memory usage on OOM and SysRq-M (v2) By: Dave Hansen on Tue, 17 April 2007 17:37
		Re: [PATCH] Show slab memory usage on OOM and SysRq-M (v2) By: Pekka Enberg on Wed, 18 April 2007 06:12
		Re: [PATCH] Show slab memory usage on OOM and SysRq-M (v2) By: xemul on Wed, 18 April 2007 06:37
		Re: [PATCH] Show slab memory usage on OOM and SysRq-M (v2) By: Pekka Enberg on Wed, 18 April 2007 06:24
		Re: [PATCH] Show slab memory usage on OOM and SysRq-M (v2) By: xemul on Wed, 18 April 2007 06:58

Previous Topic:	[PATCH] Introduce a handy list_first_entry macro (v2)
Next Topic:	[PATCH] Introduce a handy list_first_entry macro

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sat Jul 26 22:50:48 GMT 2025

Total time taken to generate the page: 0.35192 seconds