OpenVZ Forum: Devel » [PATCH] Don't attach callback to a going-away netlink socket

Home » Mailing lists » Devel » [PATCH] Don't attach callback to a going-away netlink socket

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH] Don't attach callback to a going-away netlink socket [message #12049 is a reply to message #12046]

Mon, 16 April 2007 12:55

Patrick McHardy
Messages: 107
Registered: March 2006

Senior Member

Pavel Emelianov wrote:
> Patrick McHardy wrote:
>
>>>There is a race between netlink_dump_start() and netlink_release()
>>>that can lead to the situation when a netlink socket with non-zero
>>>callback is freed.
>>
>>
>>Can you describe the race in more detail please?
>>
>
> Here it is:
>
> [...]
> The proposal it to make sock_orphan before detaching the callback
> in netlink_release() and to check for the sock to be SOCK_DEAD in
> netlink_dump_start() before setting a new callback.

Thanks, good catch. Your patch also looks good.

Acked-by: Patrick McHardy <kaber@trash.net>

Report message to a moderator

[Message index]

		[PATCH] Don't attach callback to a going-away netlink socket By: xemul on Mon, 16 April 2007 11:34
		Re: [PATCH] Don't attach callback to a going-away netlink socket By: Patrick McHardy on Mon, 16 April 2007 11:41
		Re: [PATCH] Don't attach callback to a going-away netlink socket By: xemul on Mon, 16 April 2007 11:53
		Re: [PATCH] Don't attach callback to a going-away netlink socket By: Patrick McHardy on Mon, 16 April 2007 12:55
		Re: [PATCH] Don't attach callback to a going-away netlink socket By: James Morris on Mon, 16 April 2007 12:37

Previous Topic:	How to query mount propagation state?
Next Topic:	[PATCH] Report that kernel is tainted if there were an OOPS before

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Mon Feb 16 18:56:01 GMT 2026

Total time taken to generate the page: 0.19064 seconds