OpenVZ Forum: Devel » [PATCH RESEND 2/2] Fix some kallsyms

Home » Mailing lists » Devel » [PATCH RESEND 2/2] Fix some kallsyms_lookup() vs rmmod races

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH RESEND 2/2] Fix some kallsyms_lookup() vs rmmod races [message #11306 is a reply to message #11268]

Sat, 17 March 2007 09:37

Rusty Russell
Messages: 10
Registered: March 2007

Junior Member

On Fri, 2007-03-16 at 12:51 +0100, Ingo Molnar wrote:
> * Alexey Dobriyan <adobriyan@sw.ru> wrote:
>
> > [cc'ing folks whose proc files are affected]
> >
> > kallsyms_lookup() can call module_address_lookup() which iterates over
> > modules list without module_mutex taken. Comment at the top of
> > module_address_lookup() says it's for oops resolution so races are
> > irrelevant, but in some cases it's reachable from regular code:
>
> looking at the problem from another angle: wouldnt this be something
> that would benefit from freeze_processes()/unfreeze_processes(), and
> hence no locking would be required?

Actually, the list manipulation is done with stop_machine for this
reason. Alexey, is preempt enabled in your kernel?

Rusty.

Report message to a moderator

[Message index]

		[PATCH RESEND 2/2] Fix some kallsyms_lookup() vs rmmod races By: Alexey Dobriyan on Fri, 16 March 2007 11:39
		Re: [PATCH RESEND 2/2] Fix some kallsyms_lookup() vs rmmod races By: Ingo Molnar on Fri, 16 March 2007 11:51
		Re: [PATCH RESEND 2/2] Fix some kallsyms_lookup() vs rmmod races By: Paulo Marques on Fri, 16 March 2007 16:16
		Re: [PATCH RESEND 2/2] Fix some kallsyms_lookup() vs rmmod races By: Ingo Molnar on Fri, 16 March 2007 16:18
		Re: [PATCH RESEND 2/2] Fix some kallsyms_lookup() vs rmmod races By: Paulo Marques on Fri, 16 March 2007 17:16
		Re: [PATCH RESEND 2/2] Fix some kallsyms_lookup() vs rmmod races By: Andrew Morton on Fri, 16 March 2007 18:15
		Re: [PATCH RESEND 2/2] Fix some kallsyms_lookup() vs rmmod races By: Paulo Marques on Fri, 16 March 2007 20:27
		Re: [PATCH RESEND 2/2] Fix some kallsyms_lookup() vs rmmod races By: Andrew Morton on Fri, 16 March 2007 20:49
		Re: [PATCH RESEND 2/2] Fix some kallsyms_lookup() vs rmmod races By: Rusty Russell on Sat, 17 March 2007 10:36
		Re: [PATCH RESEND 2/2] Fix some kallsyms_lookup() vs rmmod races By: Alexey Dobriyan on Mon, 19 March 2007 09:50
		Re: [PATCH RESEND 2/2] Fix some kallsyms_lookup() vs rmmod races By: Rusty Russell on Sat, 17 March 2007 09:37
		Re: [PATCH RESEND 2/2] Fix some kallsyms_lookup() vs rmmod races By: Alexey Dobriyan on Mon, 19 March 2007 10:14
		Re: [PATCH RESEND 2/2] Fix some kallsyms_lookup() vs rmmod races By: Paulo Marques on Mon, 19 March 2007 15:17
		Re: [PATCH RESEND 2/2] Fix some kallsyms_lookup() vs rmmod races By: Rusty Russell on Mon, 19 March 2007 23:23
		Re: [PATCH RESEND 2/2] Fix some kallsyms_lookup() vs rmmod races By: Rusty Russell on Sat, 17 March 2007 09:32

Previous Topic:	[PATCH] p4-clockmod: switch to rdmsr_on_cpu/wrmsr_on_cpu
Next Topic:	[PATCH RESEND 1/2] Race between cat /proc/kallsyms and rmmod

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Wed May 27 09:32:00 GMT 2026

Total time taken to generate the page: 0.32011 seconds