OpenVZ Forum: Devel » [RFC][PATCH 0/7] Resource controllers based on process containers

Home » Mailing lists » Devel » [RFC][PATCH 0/7] Resource controllers based on process containers

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: Re: [RFC][PATCH 2/7] RSS controller core [message #11104 is a reply to message #11079]

Tue, 13 March 2007 15:30

dev
Messages: 1693
Registered: September 2005
Location: Moscow

Senior Member

Eric,

>>>And misses every resource sharing opportunity in sight.
>>
>>that was my point too.
>>
>>
>>>Except for
>>>filtering the which pages are eligible for reclaim an RSS limit should
>>>not need to change the existing reclaim logic, and with things like the
>>>memory zones we have had that kind of restriction in the reclaim logic
>>>for a long time. So filtering out ineligible pages isn't anything new.
>>
>>exactly this is implemented in the current patches from Pavel.
>>the only difference is that filtering is not done in general LRU list,
>>which is not effective, but via per-container LRU list.
>>So the pointer on the page structure does 2 things:
>>- fast reclamation
>
> Better than the rmap list?
>
>>- correct uncharging of page from where it was charged
>> (e.g. shared pages can be mapped first in one container, but the last unmap
>> done from another one).
>
> We should charge/uncharge all of them, not just one.
>
>
>>>>We need to work out what the requirements are before we can settle on an
>>>>implementation.
>>>
>>>
>>>If you are talking about RSS limits the term is well defined. The
>>>number of pages you can have mapped into your set of address space at
>>>any given time.
>>>
>>>Unless I'm totally blind that isn't what the patchset implements.
>>
>>Ouch, what makes you think so?
>>The fact that a page mapped into 2 different processes is charged only once?
>>Imho it is much more correct then sum of process' RSS within container, due to:
>>1. it is clear how much container uses physical pages, not abstract items
>>2. shared pages are charged only once, so the sum of containers RSS is still
>> about physical RAM.
>
>
> No the fact that a page mapped into 2 separate mm_structs in two
> separate accounting domains is counted only once. This is very likely
> to happen with things like glibc if you have a read-only shared copy
> of your distro. There appears to be no technical reason for such a
> restriction.
>
> A page should not be owned.

I would be happy to propose OVZ approach then, where a page is tracked
with page_beancounter data structure, which ties together
a page with beancounters which use it like this:

page -> page_beancounter -> list of beanocunters which has the page mapped

This gives a number of advantages:
- the page is accounted to all the VEs which actually use it.
- allows almost accurate tracking of page fractions used by VEs
depending on how many VEs mapped the page.
- allows to track dirty pages, i.e. which VE dirtied the page
and implement correct disk I/O accounting and CFQ write scheduling
based on VE priorities.

> Going further unless the limits are draconian I don't expect users to
> hit the rss limits often or frequently. So in 99% of all cases page
> reclaim should continue to be global. Which makes me question messing
> with the general page reclaim lists.

It is not that rare when containers hit their limits, believe me :/
In trusted environments - probably you are right, in hosting - no.

Thanks,
Kirill

Report message to a moderator

[Message index]

		[RFC][PATCH 0/7] Resource controllers based on process containers By: xemul on Tue, 06 March 2007 14:42
		[RFC][PATCH 1/7] Resource counters By: xemul on Tue, 06 March 2007 14:47
		Re: [RFC][PATCH 1/7] Resource counters By: Balbir Singh on Wed, 07 March 2007 04:03
		Re: [RFC][PATCH 1/7] Resource counters By: xemul on Wed, 07 March 2007 07:17
		Re: [RFC][PATCH 1/7] Resource counters By: Herbert Poetzl on Fri, 09 March 2007 16:37
		Re: [RFC][PATCH 1/7] Resource counters By: xemul on Sun, 11 March 2007 09:01
		Re: [RFC][PATCH 1/7] Resource counters By: ebiederm on Sun, 11 March 2007 19:00
		Re: [RFC][PATCH 1/7] Resource counters By: Herbert Poetzl on Mon, 12 March 2007 01:16
		Re: [RFC][PATCH 1/7] Resource counters By: ebiederm on Tue, 13 March 2007 09:09
		Re: [RFC][PATCH 1/7] Resource counters By: xemul on Tue, 13 March 2007 09:27
		Re: [RFC][PATCH 1/7] Resource counters By: Herbert Poetzl on Tue, 13 March 2007 15:21
		Re: [RFC][PATCH 1/7] Resource counters By: xemul on Tue, 13 March 2007 15:41
		Re: [RFC][PATCH 1/7] Resource counters By: Srivatsa Vaddagiri on Tue, 13 March 2007 16:07
		Re: [RFC][PATCH 1/7] Resource counters By: xemul on Wed, 14 March 2007 07:12
		Re: [RFC][PATCH 1/7] Resource counters By: ebiederm on Thu, 15 March 2007 16:51
		Re: Re: [RFC][PATCH 1/7] Resource counters By: dev on Tue, 13 March 2007 09:36
		Re: [RFC][PATCH 1/7] Resource counters By: Herbert Poetzl on Tue, 13 March 2007 16:32
		[RFC][PATCH 2/7] RSS controller core By: xemul on Tue, 06 March 2007 14:53
		Re: [RFC][PATCH 2/7] RSS controller core By: Andrew Morton on Tue, 06 March 2007 22:00
		Re: [RFC][PATCH 2/7] RSS controller core By: dev on Sun, 11 March 2007 12:13
		Re: [RFC][PATCH 2/7] RSS controller core By: Andrew Morton on Sun, 11 March 2007 12:51
		Re: [RFC][PATCH 2/7] RSS controller core By: Balbir Singh on Sun, 11 March 2007 15:51
		Re: [RFC][PATCH 2/7] RSS controller core By: ebiederm on Sun, 11 March 2007 19:34
		Re: [RFC][PATCH 2/7] RSS controller core By: Herbert Poetzl on Mon, 12 March 2007 01:00
		Re: [RFC][PATCH 2/7] RSS controller core By: Dave Hansen on Mon, 12 March 2007 18:42
		Re: [RFC][PATCH 2/7] RSS controller core By: Herbert Poetzl on Mon, 12 March 2007 22:41
		Re: [RFC][PATCH 2/7] RSS controller core By: xemul on Mon, 12 March 2007 09:02
		Re: [RFC][PATCH 2/7] RSS controller core By: Herbert Poetzl on Mon, 12 March 2007 21:11
		Re: [RFC][PATCH 2/7] RSS controller core By: xemul on Tue, 13 March 2007 07:17
		Re: [RFC][PATCH 2/7] RSS controller core By: Herbert Poetzl on Tue, 13 March 2007 15:05
		Re: [RFC][PATCH 2/7] RSS controller core By: xemul on Tue, 13 March 2007 15:32
		Re: [RFC][PATCH 2/7] RSS controller core By: dev on Tue, 13 March 2007 15:10
		Re: Re: [RFC][PATCH 2/7] RSS controller core By: Kirill Korotaev on Mon, 12 March 2007 09:10
		Re: Re: [RFC][PATCH 2/7] RSS controller core By: ebiederm on Tue, 13 March 2007 09:26
		Re: Re: [RFC][PATCH 2/7] RSS controller core By: dev on Tue, 13 March 2007 15:30
		Re: Re: [RFC][PATCH 2/7] RSS controller core By: dev on Tue, 13 March 2007 10:06
		Re: Re: [RFC][PATCH 2/7] RSS controller core By: Andrew Morton on Tue, 13 March 2007 10:49
		Re: Re: [RFC][PATCH 2/7] RSS controller core By: Herbert Poetzl on Tue, 13 March 2007 14:59
		Re: [RFC][PATCH 2/7] RSS controller core By: Dave Hansen on Tue, 13 March 2007 17:05
		Re: [RFC][PATCH 2/7] RSS controller core By: mel on Wed, 14 March 2007 15:38
		Re: Re: [RFC][PATCH 2/7] RSS controller core By: Paul Menage on Sun, 18 March 2007 22:44
		Re: Re: [RFC][PATCH 2/7] RSS controller core By: ebiederm on Mon, 19 March 2007 17:41
		Re: [RFC][PATCH 2/7] RSS controller core By: Herbert Poetzl on Fri, 09 March 2007 16:48
		Re: [RFC][PATCH 2/7] RSS controller core By: xemul on Sun, 11 March 2007 09:08
		Re: [RFC][PATCH 2/7] RSS controller core By: Herbert Poetzl on Sun, 11 March 2007 14:32
		Re: [RFC][PATCH 2/7] RSS controller core By: xemul on Sun, 11 March 2007 15:04
		Re: [RFC][PATCH 2/7] RSS controller core By: Herbert Poetzl on Mon, 12 March 2007 00:41
		Re: [RFC][PATCH 2/7] RSS controller core By: xemul on Mon, 12 March 2007 08:31
		Re: [RFC][PATCH 2/7] RSS controller core By: Balbir Singh on Mon, 12 March 2007 09:55
		Re: [RFC][PATCH 2/7] RSS controller core By: Herbert Poetzl on Mon, 12 March 2007 23:43
		Re: [RFC][PATCH 2/7] RSS controller core By: Balbir Singh on Tue, 13 March 2007 01:57
		Re: [RFC][PATCH 2/7] RSS controller core By: Srivatsa Vaddagiri on Tue, 13 March 2007 02:24
		Re: [RFC][PATCH 2/7] RSS controller core By: Herbert Poetzl on Tue, 13 March 2007 16:06
		Re: [RFC][PATCH 2/7] RSS controller core By: Balbir Singh on Wed, 07 March 2007 05:37
		Re: [RFC][PATCH 2/7] RSS controller core By: xemul on Wed, 07 March 2007 07:25
		Re: [RFC][PATCH 2/7] RSS controller core By: Dave Hansen on Mon, 12 March 2007 23:02
		Re: [RFC][PATCH 2/7] RSS controller core By: ebiederm on Sun, 18 March 2007 16:58
		Re: [RFC][PATCH 2/7] RSS controller core By: akpm on Tue, 13 March 2007 06:04
		Re: [RFC][PATCH 2/7] RSS controller core By: Dave Hansen on Tue, 13 March 2007 17:26
		Re: [RFC][PATCH 2/7] RSS controller core By: Alan Cox on Tue, 13 March 2007 19:09
		Re: [RFC][PATCH 2/7] RSS controller core By: ebiederm on Fri, 16 March 2007 00:55
		Re: [RFC][PATCH 2/7] RSS controller core By: Dave Hansen on Fri, 16 March 2007 16:31
		Re: [RFC][PATCH 2/7] RSS controller core By: ebiederm on Fri, 16 March 2007 18:54
		Re: [RFC][PATCH 2/7] RSS controller core By: mel on Wed, 14 March 2007 16:47
		Re: [RFC][PATCH 2/7] RSS controller core By: Dave Hansen on Tue, 13 March 2007 20:28
		Re: [RFC][PATCH 2/7] RSS controller core By: Herbert Poetzl on Tue, 13 March 2007 15:11
		Re: [RFC][PATCH 2/7] RSS controller core By: dev on Tue, 13 March 2007 15:54
		Re: [RFC][PATCH 2/7] RSS controller core By: Dave Hansen on Wed, 14 March 2007 20:42
		Re: [RFC][PATCH 2/7] RSS controller core By: mel on Tue, 20 March 2007 18:57
		Re: [RFC][PATCH 2/7] RSS controller core By: Dave Hansen on Fri, 16 March 2007 19:46
		Re: [RFC][PATCH 2/7] RSS controller core By: ebiederm on Sun, 18 March 2007 17:42
		Re: [RFC][PATCH 2/7] RSS controller core By: Herbert Poetzl on Mon, 19 March 2007 15:48
		controlling mmap()'d vs read/write() pages By: Dave Hansen on Tue, 20 March 2007 16:15
		Re: controlling mmap()'d vs read/write() pages By: ebiederm on Tue, 20 March 2007 21:19
		Re: controlling mmap()'d vs read/write() pages By: Herbert Poetzl on Fri, 23 March 2007 00:51
		Re: controlling mmap()'d vs read/write() pages By: Nick Piggin on Fri, 23 March 2007 05:57
		Re: controlling mmap()'d vs read/write() pages By: ebiederm on Fri, 23 March 2007 10:12
		Re: controlling mmap()'d vs read/write() pages By: Dave Hansen on Fri, 23 March 2007 16:41
		Re: controlling mmap()'d vs read/write() pages By: Herbert Poetzl on Fri, 23 March 2007 18:16
		Re: controlling mmap()'d vs read/write() pages By: Balbir Singh on Wed, 28 March 2007 09:18
		Re: controlling mmap()'d vs read/write() pages By: Nick Piggin on Fri, 23 March 2007 10:47
		Re: controlling mmap()'d vs read/write() pages By: ebiederm on Fri, 23 March 2007 12:21
		Re: controlling mmap()'d vs read/write() pages By: Nick Piggin on Wed, 28 March 2007 07:33
		[RFC][PATCH 3/7] Data structures changes for RSS accounting By: xemul on Tue, 06 March 2007 14:55
		Re: [RFC][PATCH 3/7] Data structures changes for RSS accounting By: ebiederm on Sun, 11 March 2007 19:13
		Re: [RFC][PATCH 3/7] Data structures changes for RSS accounting By: dev on Mon, 12 March 2007 16:16
		Re: [RFC][PATCH 3/7] Data structures changes for RSS accounting By: Dave Hansen on Mon, 12 March 2007 16:48
		Re: [RFC][PATCH 3/7] Data structures changes for RSS accounting By: xemul on Mon, 12 March 2007 17:19
		Re: [RFC][PATCH 3/7] Data structures changes for RSS accounting By: Balbir Singh on Mon, 12 March 2007 17:21
		Re: [RFC][PATCH 3/7] Data structures changes for RSS accounting By: Dave Hansen on Mon, 12 March 2007 17:27
		Re: [RFC][PATCH 3/7] Data structures changes for RSS accounting By: xemul on Tue, 13 March 2007 07:10
		[RFC][PATCH 4/7] RSS accounting hooks over the code By: xemul on Tue, 06 March 2007 14:57
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: xemul on Wed, 14 March 2007 15:43
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Cedric Le Goater on Wed, 14 March 2007 15:37
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: ebiederm on Sun, 11 March 2007 19:14
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: dev on Mon, 12 March 2007 16:23
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Dave Hansen on Mon, 12 March 2007 16:50
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: dev on Mon, 12 March 2007 17:07
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Herbert Poetzl on Mon, 12 March 2007 23:54
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: ebiederm on Tue, 13 March 2007 09:58
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Nick Piggin on Tue, 13 March 2007 10:25
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Ethan Solomita on Wed, 28 March 2007 20:15
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Dave Hansen on Mon, 12 March 2007 17:33
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: ebiederm on Tue, 13 March 2007 09:43
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: ebiederm on Tue, 13 March 2007 16:01
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Nick Piggin on Wed, 14 March 2007 03:51
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Balbir Singh on Wed, 14 March 2007 06:42
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Nick Piggin on Wed, 14 March 2007 06:57
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Balbir Singh on Wed, 14 March 2007 07:48
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Vaidyanathan Srinivas on Wed, 14 March 2007 13:25
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Nick Piggin on Wed, 14 March 2007 13:49
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: dev on Wed, 14 March 2007 16:16
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Nick Piggin on Thu, 15 March 2007 05:01
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Vaidyanathan Srinivas on Wed, 14 March 2007 14:43
		Re: [RFC][PATCH 4/7] RSS accounting hooks over the code By: Balbir Singh on Thu, 15 March 2007 05:44
		[RFC][PATCH 5/7] Per-container OOM killer and page reclamation By: xemul on Tue, 06 March 2007 15:01
		Re: [RFC][PATCH 5/7] Per-container OOM killer and page reclamation By: Balbir Singh on Fri, 09 March 2007 21:21
		Re: [RFC][PATCH 5/7] Per-container OOM killer and page reclamation By: xemul on Sun, 11 March 2007 08:39
		[RFC][PATCH 6/7] Account for the number of tasks within container By: xemul on Tue, 06 March 2007 15:02
		Re: [RFC][PATCH 6/7] Account for the number of tasks within container By: Paul Menage on Wed, 07 March 2007 02:00
		Re: [RFC][PATCH 6/7] Account for the number of tasks within container By: xemul on Wed, 07 March 2007 07:10
		Re: [RFC][PATCH 6/7] Account for the number of tasks within container By: Paul Menage on Thu, 08 March 2007 13:49
		Re: [RFC][PATCH 6/7] Account for the number of tasks within container By: xemul on Sun, 11 March 2007 08:34
		[RFC][PATCH 7/7] Account for the number of files opened within container By: xemul on Tue, 06 March 2007 15:05
		Re: [RFC][PATCH 0/7] Resource controllers based on process containers By: Paul Menage on Wed, 07 March 2007 02:02
		Re: [RFC][PATCH 0/7] Resource controllers based on process containers By: xemul on Wed, 07 March 2007 07:27
		Re: [RFC][PATCH 0/7] Resource controllers based on process containers By: Balbir Singh on Wed, 07 March 2007 06:52
		Re: [RFC][PATCH 0/7] Resource controllers based on process containers By: xemul on Wed, 07 March 2007 07:30
		Re: [RFC][PATCH 0/7] Resource controllers based on process containers By: dev on Wed, 07 March 2007 09:30

Previous Topic:	Re: [ckrm-tech] [PATCH 7/7] containers (V7): Container interface to nsproxy subsystem
Next Topic:	Linux-VServer example results for sharing vs. separate mappings ...

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Thu Aug 08 02:59:29 GMT 2024

Total time taken to generate the page: 0.02844 seconds