| Re: [PATCH 3/3] SPARC: Handle request_irq() failure [message #10697 is a reply to message #10684] |
Mon, 26 February 2007 17:44  |
davem
Messages: 463
Registered: February 2006
|
Senior Member |
|
|
From: Monakhov Dmitriy <dmonakhov@openvz.org>
Date: Mon, 26 Feb 2007 19:09:27 +0300
> Signed-off-by: Monakhov Dmitriy <dmonakhov@openvz.org>
...
> @@ -389,7 +390,12 @@ static int __init ts102_uctrl_init(void)
> if(!driver->irq)
> driver->irq = tmp_irq[0].pri;
>
> - request_irq(driver->irq, uctrl_interrupt, 0, "uctrl", driver);
> + err = request_irq(driver->irq, uctrl_interrupt, 0, "uctrl", driver);
> + if (err) {
> + printk(KERN_ERR "%s: unable to request irq %d\n",
> + __FUNCTION__, driver->irq);
> + return -EBUSY;
> + }
>
Why not return the error code that request_irq() gave us?
That's how I'll fix this bug.
|
|
|
|
OpenVZ Forum
Members
Search
Help
Register
Login
Home
