| Re: [RFC PATCH 2/4] namespace containers: move nsproxy setting code [message #10251 is a reply to message #10225] |
Tue, 13 February 2007 16:25  |
serue
Messages: 750
Registered: February 2006
|
Senior Member |
|
|
Quoting Paul Menage (menage@google.com):
> On 2/12/07, Serge E. Hallyn <serue@us.ibm.com> wrote:
> >From: "Serge E. Hallyn" <serue@us.ibm.com>
> >Subject: [RFC PATCH 2/4] namespace containers: move nsproxy setting code
> >
> >Move nsproxy setting code from clone and unshare into container_clone.
>
> Please can you keep the knowledge of nsproxy outside of the generic
> container code? If there's some additional work required by a
> subsystem when a container is cloned, we should have additional
> callbacks.
>
> But in this case, can't you just do the swap_nsproxies() in
> ns_container_clone(), either before or after calling
> container_clone()?
I guess that's fine. I was doing it as late as possible because I
was worried about failure later on, but the callers handle failure
appropriately so it should be fine.
thanks,
-serge
|
|
|
|
OpenVZ Forum
Members
Search
Help
Register
Login
Home
