| gentoo baselayout 1.13 openvz modifications [message #9789] | 
			Mon, 22 January 2007 14:58   | 
		 
		
			| 
				
	 | 
 
	
		Hello, 
 
I was checking the stuff added to Gentoo's baselayout 1.13 to make it  
compatible with VPS systems like Linux-VServer or OpenVZ. 
 
Everything looks great, the only minor problem I found is this code in  
bootmisc: 
 
        if [[ $(uname) == "Linux" ]]  && ! is_vps_sys ; then 
                # BSD has it's own sysctl init script 
                if [[ -e /etc/sysctl.conf ]] ; then 
                        ebegin $"Configuring kernel parameters" 
                        sysctl -q -p /etc/sysctl.conf 
                        eend $? 
                fi 
        fi 
 
The problem here is in OpenVZ some of sysctl variables are virtualized,  
i.e. you can set it from inside your VE. Usually this is not needed, and  
not too many people do that, but still if there is /etc/sysctl.conf  
people expect that it will be applied during VE start. 
 
Surely this is minor problem and it does not cry for fixing it now.  
Still, at the very least it would be helpful to add FIXME or TODO-like  
comment in the code. 
 
Regards, 
  Kir. 
 
 
PS version checked is baselayout-1.13.0_alpha12
		
		
		
 |  
	| 
		
	 | 
 
 
 | 
	
		
		
			| Re: gentoo baselayout 1.13 openvz modifications [message #9874 is a reply to message #9789] | 
			Fri, 26 January 2007 16:43   | 
		 
		
			
				
				
				
					
						  
						hollow
						 Messages: 2 Registered: December 2006 
						
					 | 
					Junior Member  | 
					 | 
		 
		 
	 | 
 
	
		On Friday 26 January 2007 17:02, Roy Marples wrote: 
> On Mon, 22 Jan 2007 17:58:05 +0300 
> 
> Kir Kolyshkin <kir@openvz.org> wrote: 
> > I was checking the stuff added to Gentoo's baselayout 1.13 to make it 
> > compatible with VPS systems like Linux-VServer or OpenVZ. 
> > 
> > Everything looks great, the only minor problem I found is this code 
> > in bootmisc: 
> > 
> >         if [[ $(uname) == "Linux" ]]  && ! is_vps_sys ; then 
> >                 # BSD has it's own sysctl init script 
> >                 if [[ -e /etc/sysctl.conf ]] ; then 
> >                         ebegin $"Configuring kernel parameters" 
> >                         sysctl -q -p /etc/sysctl.conf 
> >                         eend $? 
> >                 fi 
> >         fi 
> > 
> > The problem here is in OpenVZ some of sysctl variables are 
> > virtualized, i.e. you can set it from inside your VE. Usually this is 
> > not needed, and not too many people do that, but still if there 
> > is /etc/sysctl.conf people expect that it will be applied during VE 
> > start. 
> 
> Hollow asked for that for a reason. I'll assume that he's on the 
> vserver-devs@gentoo.org mailing list and he'll tell me why. 
> 
> Otherwise I have no problem with punting it myself. 
> 
> Thanks 
> 
> Roy 
 
Yeah, we can punt that...
		
		
		
 |  
	| 
		
	 | 
 
 
 | 
	
		
		
			| Re: gentoo baselayout 1.13 openvz modifications [message #9882 is a reply to message #9789] | 
			Fri, 26 January 2007 16:02   | 
		 
		
			
				
				
				
					
						  
						Roy Marples
						 Messages: 1 Registered: January 2007 
						
					 | 
					Junior Member  | 
					 | 
		 
		 
	 | 
 
	
		On Mon, 22 Jan 2007 17:58:05 +0300 
Kir Kolyshkin <kir@openvz.org> wrote: 
> I was checking the stuff added to Gentoo's baselayout 1.13 to make it  
> compatible with VPS systems like Linux-VServer or OpenVZ. 
>  
> Everything looks great, the only minor problem I found is this code 
> in bootmisc: 
>  
>         if [[ $(uname) == "Linux" ]]  && ! is_vps_sys ; then 
>                 # BSD has it's own sysctl init script 
>                 if [[ -e /etc/sysctl.conf ]] ; then 
>                         ebegin $"Configuring kernel parameters" 
>                         sysctl -q -p /etc/sysctl.conf 
>                         eend $? 
>                 fi 
>         fi 
>  
> The problem here is in OpenVZ some of sysctl variables are 
> virtualized, i.e. you can set it from inside your VE. Usually this is 
> not needed, and not too many people do that, but still if there 
> is /etc/sysctl.conf people expect that it will be applied during VE 
> start. 
 
Hollow asked for that for a reason. I'll assume that he's on the 
vserver-devs@gentoo.org mailing list and he'll tell me why. 
 
Otherwise I have no problem with punting it myself. 
 
Thanks 
 
Roy
		
		
		
 |  
	| 
		
	 | 
 
 
 |