OpenVZ Forum: Devel » [PATCH] xfs: add newline in debug messages

Home » Mailing lists » Devel » [PATCH] xfs: add newline in debug messages

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [xfs-masters] [PATCH] xfs: add newline in debug messages [message #9397 is a reply to message #9393]

Sat, 30 December 2006 18:40

Eric Sandeen
Messages: 4
Registered: September 2006

Junior Member

Alexey Dobriyan wrote:
> cmn_err(CE_DEBUG, ...); doesn't add newline for you.

The patch looks about right to me. This -is- how it was -intended- to
be used.

However, the no-newline behavior is so rarely used that I almost wonder
if it'd be more straightforward to drop it, and instead use sprintf or
something to construct those strings... otherwise I'm sure that future
CE_DEBUG messages will forget newlines as well.

-Eric

Report message to a moderator

[Message index]

		[PATCH] xfs: add newline in debug messages By: adobriyan on Fri, 29 December 2006 15:11
		Re: [xfs-masters] [PATCH] xfs: add newline in debug messages By: Eric Sandeen on Sat, 30 December 2006 18:40

Previous Topic:	[RFC] Use jiffies_64 in sched_clock()
Next Topic:	[PATCH] xt_hashlimit.c: fix typo

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Fri Oct 10 17:36:19 GMT 2025

Total time taken to generate the page: 0.10951 seconds