OpenVZ Forum: Devel » Re: [patch -mm 16/17] net namespace: add unshare

Home » Mailing lists » Devel » Re: [patch -mm 16/17] net namespace: add unshare

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [patch -mm 16/17] net namespace: add unshare [message #8743]

Tue, 05 December 2006 10:46

Mishin Dmitry
Messages: 112
Registered: February 2006

Senior Member

Cedric,

On Tuesday 05 December 2006 13:28, clg@fr.ibm.com wrote:
[skip]
>
> +static inline int unshare_net_ns(unsigned long unshare_flags,
> + struct net_namespace **new_net)
> +{
> + if (unshare_flags & NS_NET)
Where is it defined?

--
Thanks,
Dmitry.

Report message to a moderator

Re: [patch -mm 16/17] net namespace: add unshare [message #8745 is a reply to message #8743]

Tue, 05 December 2006 10:53

Daniel Lezcano
Messages: 417
Registered: June 2006

Senior Member

Dmitry Mishin wrote:
> Cedric,
>
> On Tuesday 05 December 2006 13:28, clg@fr.ibm.com wrote:
> [skip]
>> +static inline int unshare_net_ns(unsigned long unshare_flags,
>> + struct net_namespace **new_net)
>> +{
>> + if (unshare_flags & NS_NET)
> Where is it defined?

This function is for !CONFIG_NET_NS

unshare_net_ns is defined in net_namespace.c

Report message to a moderator

Re: [patch -mm 16/17] net namespace: add unshare [message #8746 is a reply to message #8745]

Tue, 05 December 2006 10:56

Mishin Dmitry
Messages: 112
Registered: February 2006

Senior Member

On Tuesday 05 December 2006 13:53, Daniel Lezcano wrote:
> Dmitry Mishin wrote:
> > Cedric,
> >
> > On Tuesday 05 December 2006 13:28, clg@fr.ibm.com wrote:
> > [skip]
> >
> >> +static inline int unshare_net_ns(unsigned long unshare_flags,
> >> + struct net_namespace **new_net)
> >> +{
> >> + if (unshare_flags & NS_NET)
> >
> > Where is it defined?
>
> This function is for !CONFIG_NET_NS
>
> unshare_net_ns is defined in net_namespace.c
Sorry for unclear question. Where is defined NS_NET? It should be CLONE_NEWNET
instead, shouldn't it?

>
--
Thanks,
Dmitry.

Report message to a moderator

Re: [patch -mm 16/17] net namespace: add unshare [message #8748 is a reply to message #8746]

Tue, 05 December 2006 11:01

Cedric Le Goater
Messages: 443
Registered: February 2006

Senior Member

> Sorry for unclear question. Where is defined NS_NET? It should be CLONE_NEWNET
> instead, shouldn't it?

if we keep on using the unshare syscall, the answer is yes.

I'm proposing a new syscall specific to namespaces (patch 10) with
a new set of flags very similar to unshare.

cheers,

c.

Report message to a moderator

Previous Topic:	Re: Network virtualization/isolation
Next Topic:	Re: [Patch 1/3] Miscellaneous container fixes

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Fri Oct 24 11:25:39 GMT 2025

Total time taken to generate the page: 0.15712 seconds