OpenVZ Forum: Devel » BC: resource beancounters (v6) (with userpages reclamation + configfs)

Home » Mailing lists » Devel » BC: resource beancounters (v6) (with userpages reclamation + configfs)

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [ckrm-tech] [PATCH 4/13] BC: context handling [message #8574 is a reply to message #8564]

Mon, 27 November 2006 08:27

Pavel Emelianov
Messages: 1149
Registered: September 2006

Senior Member

Paul Menage wrote:
> On 11/24/06, Pavel Emelianov <xemul@openvz.org> wrote:
>> I've got it! That's what will work:
>>
>> struct task_struct {
>> ...
>> struct beancounter *exec_bc;
>> struct beancounter *tmp_exec_bc; /* is set to NULL on
>> * tsk creation
>> */
>> };
>>
>> struct beancounter get_exec_bc(void)
>> {
>> if (current->tmp_exec_bc)
>> return current->tmp_exec_bc;
>> return rcu_dereference(current->exec_bc);
>> }
>
> Don't forget that this means all callers need to be in an
> rcu_read_lock() section.

Sure. This is done for these particular cases.

>>
>> I will implement this in the next beancounter patches.
>
> This is looking remarkably like the mechanism in use for my generic
> containers patches (inherited from Paul Jackson's cpusets code). In
> the last set of patches that I posted on Wednesday night, I included
> the example of the beancounters core and numfiles counter implemented
> on top of the generic containers - basically pulling out the hash
> table, refcounting and most of the configfs code (since that's handled
> by the generic containers), and moving the attribute management
> configfs code to the use the containerfs filesystem interface instead.
> The rest is pretty much unchanged.
>
> I think you could continue to use the tmp_exec_bc idea with this, and
> have get_exec_bc() use the tmp_exec_bc if it existed, or else get the
> bc pointer via the container system.

I'll look through your patches this week and send my opinion.

> I'd appreciate any feedback you had on that approach.
>
> Paul

Report message to a moderator

[Message index]

		BC: resource beancounters (v6) (with userpages reclamation + configfs) By: dev on Thu, 09 November 2006 16:42
		[PATCH 1/13] BC: atomic_dec_and_lock_irqsave() helper By: dev on Thu, 09 November 2006 16:47
		Re: [PATCH 1/13] BC: atomic_dec_and_lock_irqsave() helper By: Cedric Le Goater on Fri, 10 November 2006 15:19
		Re: [PATCH 1/13] BC: atomic_dec_and_lock_irqsave() helper By: dev on Fri, 10 November 2006 16:40
		[PATCH 2/13] BC: Kconfig and Makefile By: dev on Thu, 09 November 2006 16:47
		[PATCH 3/13] BC: beancounters core and API By: dev on Thu, 09 November 2006 16:49
		[PATCH 4/13] BC: context handling By: dev on Thu, 09 November 2006 16:51
		Re: [ckrm-tech] [PATCH 4/13] BC: context handling By: Paul Menage on Thu, 23 November 2006 07:48
		Re: [ckrm-tech] [PATCH 4/13] BC: context handling By: Pavel Emelianov on Thu, 23 November 2006 08:35
		Re: [ckrm-tech] [PATCH 4/13] BC: context handling By: Paul Menage on Thu, 23 November 2006 08:53
		Re: [ckrm-tech] [PATCH 4/13] BC: context handling By: Pavel Emelianov on Thu, 23 November 2006 09:20
		Re: [ckrm-tech] [PATCH 4/13] BC: context handling By: Paul Menage on Thu, 23 November 2006 09:31
		Re: [ckrm-tech] [PATCH 4/13] BC: context handling By: Pavel Emelianov on Thu, 23 November 2006 09:56
		Re: [ckrm-tech] [PATCH 4/13] BC: context handling By: Paul Menage on Thu, 23 November 2006 10:18
		Re: [ckrm-tech] [PATCH 4/13] BC: context handling By: Pavel Emelianov on Thu, 23 November 2006 10:45
		Re: [ckrm-tech] [PATCH 4/13] BC: context handling By: Pavel Emelianov on Fri, 24 November 2006 10:10
		Re: [ckrm-tech] [PATCH 4/13] BC: context handling By: Paul Menage on Sat, 25 November 2006 00:09
		Re: [ckrm-tech] [PATCH 4/13] BC: context handling By: Pavel Emelianov on Mon, 27 November 2006 08:27
		[PATCH 5/13] BC: configfs interface By: dev on Thu, 09 November 2006 16:52
		[PATCH 6/13] BC: kmemsize accounting (core) By: dev on Thu, 09 November 2006 16:53
		Re: [PATCH 6/13] BC: kmemsize accounting (core) By: Paul Jackson on Thu, 09 November 2006 19:05
		Re: [PATCH 6/13] BC: kmemsize accounting (core) By: Pekka Enberg on Fri, 10 November 2006 22:50
		Re: [PATCH 6/13] BC: kmemsize accounting (core) By: Pekka Enberg on Fri, 10 November 2006 22:46
		Re: [PATCH 6/13] BC: kmemsize accounting (core) By: Pavel Emelianov on Mon, 13 November 2006 12:13
		Re: [PATCH 6/13] BC: kmemsize accounting (core) By: Pavel Machek on Sat, 11 November 2006 05:50
		[PATCH 7/13] BC: kmemsize accounting (hooks) By: dev on Thu, 09 November 2006 16:54
		[PATCH 8/13] BC: privvmpages accounting (core) By: dev on Thu, 09 November 2006 16:56
		[PATCH 9/13] BC: privvmpages accounting (hooks) By: dev on Thu, 09 November 2006 16:57
		[PATCH 10/13] BC: physpages accounting (core) By: dev on Thu, 09 November 2006 16:59
		[PATCH 11/13] BC: physpages accounting (hooks) By: dev on Thu, 09 November 2006 17:01
		[PATCH 12/13] BC: numtasks accounting By: dev on Thu, 09 November 2006 17:02
		[PATCH 13/13] BC: numfiles accounting By: dev on Thu, 09 November 2006 17:03
		Re: BC: resource beancounters (v6) (with userpages reclamation + configfs) By: Herbert Poetzl on Sun, 19 November 2006 19:41

Previous Topic:	Re: Re: [RFC] [PATCH 0/4] uid_ns: introduction
Next Topic:	[PATCH] ext3: small fix for previous retries patch in ext3_prepare_write()

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sat Oct 25 17:45:20 GMT 2025

Total time taken to generate the page: 0.08879 seconds