OpenVZ Forum: Devel » [PATCH] Don't give bad kprobes example aka ")

Home » Mailing lists » Devel » [PATCH] Don't give bad kprobes example aka ") < 0))" typo

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

[PATCH] Don't give bad kprobes example aka ") < 0))" typo [message #8321]

Wed, 15 November 2006 11:50

Alexey Dobriyan
Messages: 195
Registered: August 2006

Senior Member

Signed-off-by: Alexey Dobriyan <adobriyan@openvz.org>
---

Documentation/kprobes.txt | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

--- a/Documentation/kprobes.txt
+++ b/Documentation/kprobes.txt
@@ -442,9 +442,10 @@ static int __init kprobe_init(void)
kp.fault_handler = handler_fault;
kp.symbol_name = "do_fork";

- if ((ret = register_kprobe(&kp) < 0)) {
+ ret = register_kprobe(&kp);
+ if (ret < 0) {
printk("register_kprobe failed, returned %d\n", ret);
- return -1;
+ return ret;
}
printk("kprobe registered\n");
return 0;

Report message to a moderator

Re: [PATCH] Don't give bad kprobes example aka ") < 0))" typo [message #8323 is a reply to message #8321]

Wed, 15 November 2006 11:57

Christoph Hellwig
Messages: 59
Registered: April 2006

Member

On Wed, Nov 15, 2006 at 06:56:19PM +0300, Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@openvz.org>
> ---
>
> Documentation/kprobes.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> --- a/Documentation/kprobes.txt
> +++ b/Documentation/kprobes.txt
> @@ -442,9 +442,10 @@ static int __init kprobe_init(void)
> kp.fault_handler = handler_fault;
> kp.symbol_name = "do_fork";
>
> - if ((ret = register_kprobe(&kp) < 0)) {
> + ret = register_kprobe(&kp);
> + if (ret < 0) {
> printk("register_kprobe failed, returned %d\n", ret);
> - return -1;
> + return ret;

This looks good, thanks.

Report message to a moderator

Previous Topic:	[PATCH] reiserfs: add missing D-cache flushing
Next Topic:	[PATCH] i2c-ixp4xx: fix ") != 0))" typo

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Tue Jul 22 17:47:43 GMT 2025

Total time taken to generate the page: 0.12242 seconds