| [PATCH] pata_artop: fix "& (1 >>" typo [message #8217] |
Fri, 10 November 2006 15:46  |
Alexey Dobriyan
Messages: 195
Registered: August 2006
|
Senior Member |
|
|
Signed-off-by: Alexey Dobriyan <adobriyan@openvz.org>
---
drivers/ata/pata_artop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/ata/pata_artop.c
+++ b/drivers/ata/pata_artop.c
@@ -92,7 +92,7 @@ static int artop6260_pre_reset(struct at
return -ENOENT;
pci_read_config_byte(pdev, 0x49, &tmp);
- if (tmp & (1 >> ap->port_no))
+ if (tmp & (1 << ap->port_no))
ap->cbl = ATA_CBL_PATA40;
else
ap->cbl = ATA_CBL_PATA80;
|
|
|
|
| Re: [PATCH] pata_artop: fix "& (1 >>" typo [message #8231 is a reply to message #8217] |
Fri, 10 November 2006 16:25  |
Alan Cox
Messages: 48
Registered: May 2006
|
Member |
|
|
On Fri, Nov 10, 2006 at 10:52:46PM +0300, Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@openvz.org>
Acked-by: Alan Cox <alan@redhat.com>
> ---
>
> drivers/ata/pata_artop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/ata/pata_artop.c
> +++ b/drivers/ata/pata_artop.c
> @@ -92,7 +92,7 @@ static int artop6260_pre_reset(struct at
> return -ENOENT;
>
> pci_read_config_byte(pdev, 0x49, &tmp);
> - if (tmp & (1 >> ap->port_no))
> + if (tmp & (1 << ap->port_no))
> ap->cbl = ATA_CBL_PATA40;
> else
> ap->cbl = ATA_CBL_PATA80;
--
"People who choose variable names like htlbpagek SHOULD be sent to
produce a street map of R'Lyeh. On site."
-- Al Viro
|
|
|
|
|
|
OpenVZ Forum
Members
Search
Help
Register
Login
Home
