OpenVZ Forum: Devel » [Q] missing unused dentry in prune

Home » Mailing lists » Devel » [Q] missing unused dentry in prune_dcache()?

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

[Q] missing ->d_delete() in shrink_dcache_for_umount()? [message #7951 is a reply to message #7784]

Tue, 31 October 2006 13:24

vaverin
Messages: 708
Registered: September 2005

Senior Member

David,

Vasily Averin wrote:
> Hello folks,
>
> I would like to ask you clarify me one question in the the following patch:
> http://linux.bkbits.net:8080/linux-2.6/gnupatch@449b144ecSF1 rYskg3q-SeR2vf88zg
> # ChangeSet
> # 2006/06/22 15:05:57-07:00 neilb@suse.de
> # [PATCH] Fix dcache race during umount
>
> # If prune_dcache finds a dentry that it cannot free, it leaves it where it
> # is (at the tail of the list) and exits, on the assumption that some other
> # thread will be removing that dentry soon.

It looks like I've noticed yet one suspicious place in your patch. As far as I
see you have removed dput(root) call in shrink_dcache_for_umount() function.
However I would note that dput contains ->d_delete() call that is missing in
your function:

if (dentry->d_op && dentry->d_op->d_delete) {
if (dentry->d_op->d_delete(dentry))
goto unhash_it;

I'm not sure but it seems to me some (probably out-of-tree) filesystems can do
something useful in this place.

Thank you,
Vasily Averin

Report message to a moderator

[Message index]

		[Q] missing unused dentry in prune_dcache()? By: vaverin on Wed, 25 October 2006 12:30
		Re: [Q] missing unused dentry in prune_dcache()? By: vaverin on Wed, 25 October 2006 13:58
		Re: [Q] missing unused dentry in prune_dcache()? By: David Howells on Wed, 25 October 2006 14:23
		Re: [Q] missing unused dentry in prune_dcache()? By: vaverin on Thu, 26 October 2006 11:36
		Re: [Q] missing unused dentry in prune_dcache()? By: David Howells on Thu, 26 October 2006 13:25
		Re: [Q] missing unused dentry in prune_dcache()? By: vaverin on Fri, 27 October 2006 08:05
		Re: [Q] missing unused dentry in prune_dcache()? By: David Howells on Fri, 27 October 2006 10:42
		Re: [Q] missing unused dentry in prune_dcache()? By: vaverin on Fri, 27 October 2006 11:50
		Re: [Q] missing unused dentry in prune_dcache()? By: David Howells on Fri, 27 October 2006 12:11
		Re: [Q] missing unused dentry in prune_dcache()? By: vaverin on Fri, 27 October 2006 13:47
		Re: [Q] missing unused dentry in prune_dcache()? By: David Howells on Fri, 27 October 2006 14:29
		Re: [Q] missing unused dentry in prune_dcache()? By: dev on Fri, 27 October 2006 14:34
		[PATCH 2.6.19-rc3] VFS: per-sb dentry lru list By: vaverin on Fri, 27 October 2006 14:05
		Re: [PATCH 2.6.19-rc3] VFS: per-sb dentry lru list By: Andrew Morton on Fri, 27 October 2006 18:06
		Re: [PATCH 2.6.19-rc3] VFS: per-sb dentry lru list By: vaverin on Mon, 30 October 2006 14:24
		Re: [PATCH 2.6.19-rc3] VFS: per-sb dentry lru list By: Eric Dumazet on Mon, 30 October 2006 15:08
		Re: [PATCH 2.6.19-rc3] VFS: per-sb dentry lru list By: dev on Mon, 30 October 2006 15:27
		Re: [PATCH 2.6.19-rc3] VFS: per-sb dentry lru list By: Eric Dumazet on Mon, 30 October 2006 16:09
		Re: [PATCH 2.6.19-rc3] VFS: per-sb dentry lru list By: dev on Mon, 30 October 2006 15:06
		Re: [PATCH 2.6.19-rc3] VFS: per-sb dentry lru list By: David Chinner on Mon, 30 October 2006 04:24
		Re: Re: [PATCH 2.6.19-rc3] VFS: per-sb dentry lru list By: dev on Mon, 30 October 2006 06:22
		Re: Re: [PATCH 2.6.19-rc3] VFS: per-sb dentry lru list By: Neil Brown on Tue, 31 October 2006 04:38
		Re: Re: [PATCH 2.6.19-rc3] VFS: per-sb dentry lru list By: David Howells on Tue, 31 October 2006 10:40
		Re: Re: [PATCH 2.6.19-rc3] VFS: per-sb dentry lru list By: Neil Brown on Wed, 01 November 2006 06:32
		Re: Re: [PATCH 2.6.19-rc3] VFS: per-sb dentry lru list By: vaverin on Wed, 01 November 2006 13:32
		Re: Re: [PATCH 2.6.19-rc3] VFS: per-sb dentry lru list By: Neil Brown on Tue, 14 November 2006 05:44
		Re: [PATCH 2.6.19-rc3] VFS: per-sb dentry lru list By: vaverin on Tue, 14 November 2006 06:12
		Re: [PATCH 2.6.19-rc3] VFS: per-sb dentry lru list By: vaverin on Tue, 31 October 2006 13:08
		Re: Re: [PATCH 2.6.19-rc3] VFS: per-sb dentry lru list By: dev on Wed, 01 November 2006 10:48
		Re: Re: [PATCH 2.6.19-rc3] VFS: per-sb dentry lru list By: Neil Brown on Tue, 14 November 2006 04:51
		Re: Re: [PATCH 2.6.19-rc3] VFS: per-sb dentry lru list By: David Howells on Tue, 14 November 2006 09:29
		[PATCH 2.6.19-rc3] VFS: missing unused dentry in prune_dcache() By: vaverin on Fri, 27 October 2006 13:42
		Re: [PATCH 2.6.19-rc3] VFS: missing unused dentry in prune_dcache() By: David Howells on Fri, 27 October 2006 14:24
		Re: [Q] missing unused dentry in prune_dcache()? By: David Howells on Wed, 25 October 2006 13:51
		Re: [Q] missing unused dentry in prune_dcache()? By: vaverin on Thu, 26 October 2006 11:49
		Re: [Q] missing unused dentry in prune_dcache()? By: David Howells on Thu, 26 October 2006 12:33
		Re: [Q] missing unused dentry in prune_dcache()? By: David Howells on Thu, 26 October 2006 13:23
		Re: [Q] missing unused dentry in prune_dcache()? By: vaverin on Thu, 26 October 2006 13:58
		Re: [Q] missing unused dentry in prune_dcache()? By: David Howells on Thu, 26 October 2006 14:07
		Re: [Q] missing unused dentry in prune_dcache()? By: vaverin on Fri, 27 October 2006 06:32
		Re: [Q] missing unused dentry in prune_dcache()? By: vaverin on Fri, 27 October 2006 06:50
		Re: [Q] missing unused dentry in prune_dcache()? By: David Howells on Fri, 27 October 2006 09:36
		[Q] missing ->d_delete() in shrink_dcache_for_umount()? By: vaverin on Tue, 31 October 2006 13:24
		Re: [Q] missing ->d_delete() in shrink_dcache_for_umount()? By: David Howells on Tue, 31 October 2006 15:06

Previous Topic:	[PATCH]: OOM can panic due to processes stuck in __alloc_pages()
Next Topic:	[PATCH] move_task_off_dead_cpu() should be called with disabled ints

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sun Jul 27 10:43:28 GMT 2025

Total time taken to generate the page: 0.49075 seconds