OpenVZ Forum: Devel » [PATCH] iptables compat code error way & module refcounting fix

Home » Mailing lists » Devel » [PATCH] iptables compat code error way & module refcounting fix

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH] iptables compat code error way & module refcounting fix [message #7921 is a reply to message #7919]

Mon, 30 October 2006 16:04

Patrick McHardy
Messages: 107
Registered: March 2006

Senior Member

Dmitry Mishin wrote:
> On Monday 30 October 2006 18:45, Patrick McHardy wrote:
>
>>This doesn't look right, if we fail at xt_alloc_table_info for
>>example the module references are not released.
>
> module references will be released because of 'goto out;' line just after
> xt_compat_unlock() - it is missed because of standard +-3 lines patch
> context, sorry.

You're right, I misread the code. Applied, thanks.

Report message to a moderator

[Message index]

		[PATCH] iptables compat code error way & module refcounting fix By: Mishin Dmitry on Mon, 30 October 2006 10:31
		Re: [PATCH] iptables compat code error way & module refcounting fix By: Mishin Dmitry on Mon, 30 October 2006 15:57
		Re: [PATCH] iptables compat code error way & module refcounting fix By: Patrick McHardy on Mon, 30 October 2006 16:04
		Re: [PATCH] iptables compat code error way & module refcounting fix By: Patrick McHardy on Mon, 30 October 2006 15:45

Previous Topic:	[PATCH 2.6.19-rc3-mm1] VFS: BKL is not required for remount_fs()
Next Topic:	Re: [ckrm-tech] [RFC] Resource Management - Infrastructure choices

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Tue Feb 17 21:43:25 GMT 2026

Total time taken to generate the page: 0.15669 seconds