OpenVZ Forum


Home » Mailing lists » Devel » Remove logmessage when entering VE
Remove logmessage when entering VE [message #7258] Mon, 09 October 2006 10:05 Go to next message
kfh is currently offline  kfh
Messages: 28
Registered: October 2006
Junior Member
Hi list,

Patch removing logmessage "Open /dev/pts/X"
from src/enter.c when entering VE

Before:
# vzctl enter 1010
entered into VE 1010
Open /dev/pts/0
root@dev-test2:/#

After:
# vzctl enter 1010
entered into VE 1010
root@dev-test2:/#

Best regards,
Kristian Høgh
Segtel A/S
Re: Remove logmessage when entering VE [message #7265 is a reply to message #7258] Mon, 09 October 2006 12:43 Go to previous messageGo to next message
Mishin Dmitry is currently offline  Mishin Dmitry
Messages: 112
Registered: February 2006
Senior Member
On Monday 09 October 2006 14:05, Kristian F. Høgh wrote:
> Hi list,
>
> Patch removing logmessage "Open /dev/pts/X"
> from src/enter.c when entering VE
>
> Before:
> # vzctl enter 1010
> entered into VE 1010
> Open /dev/pts/0
> root@dev-test2:/#
>
> After:
> # vzctl enter 1010
> entered into VE 1010
> root@dev-test2:/#
This is useful debug message, why to remove it?
If the problem is that the next line is shifted, then we need another fix.

>
> Best regards,
> Kristian Høgh
> Segtel A/S

--
Thanks,
Dmitry.
Re: Remove logmessage when entering VE [message #7267 is a reply to message #7265] Mon, 09 October 2006 12:55 Go to previous messageGo to next message
dev is currently offline  dev
Messages: 1693
Registered: September 2005
Location: Moscow
Senior Member

Kristian,

have you raised your default vzctl loglevel?
if so, then dim@ is right. you are using verbose mode.
and the shifted command line should be fixed then.

Thanks,
Kirill



>>Hi list,
>>
>>Patch removing logmessage "Open /dev/pts/X"
>>from src/enter.c when entering VE
>>
>>Before:
>># vzctl enter 1010
>>entered into VE 1010
>>Open /dev/pts/0
>> root@dev-test2:/#
>>
>>After:
>># vzctl enter 1010
>>entered into VE 1010
>>root@dev-test2:/#
>
> This is useful debug message, why to remove it?
> If the problem is that the next line is shifted, then we need another fix.
>
>
>>Best regards,
>>Kristian Høgh
>>Segtel A/S
>
>
Re: Remove logmessage when entering VE [message #7269 is a reply to message #7267] Mon, 09 October 2006 13:22 Go to previous messageGo to next message
kfh is currently offline  kfh
Messages: 28
Registered: October 2006
Junior Member
Well, well.
Yes, I have
LOG_LEVEL=9

So loglevel is for console/terminal and logfile.
I want information in my logfile, but a quiet console.

Regards,
Kristian.

On Monday den 9. October 2006 15:01, Kirill Korotaev wrote:
> Kristian,
>
> have you raised your default vzctl loglevel?
> if so, then dim@ is right. you are using verbose mode.
> and the shifted command line should be fixed then.
>
> Thanks,
> Kirill
>
> >>Hi list,
> >>
> >>Patch removing logmessage "Open /dev/pts/X"
> >>from src/enter.c when entering VE
> >>
> >>Before:
> >># vzctl enter 1010
> >>entered into VE 1010
> >>Open /dev/pts/0
> >> root@dev-test2:/#
> >>
> >>After:
> >># vzctl enter 1010
> >>entered into VE 1010
> >>root@dev-test2:/#
> >
> > This is useful debug message, why to remove it?
> > If the problem is that the next line is shifted, then we need another
> > fix.
> >
> >>Best regards,
> >>Kristian Høgh
> >>Segtel A/S
>
Re: Remove logmessage when entering VE [message #7275 is a reply to message #7269] Mon, 09 October 2006 16:57 Go to previous messageGo to next message
dev is currently offline  dev
Messages: 1693
Registered: September 2005
Location: Moscow
Senior Member

Mmm, I can't see many usecases... can you describe how you use it?
usually higher log levels are needed for debugging only...

I suppose CONSOLE_LEVEL option can be added.
Care to make a patch?

Thanks,
Kirill

> Well, well.
> Yes, I have
> LOG_LEVEL=9
>
> So loglevel is for console/terminal and logfile.
> I want information in my logfile, but a quiet console.
>
> Regards,
> Kristian.
>
> On Monday den 9. October 2006 15:01, Kirill Korotaev wrote:
>
>>Kristian,
>>
>>have you raised your default vzctl loglevel?
>>if so, then dim@ is right. you are using verbose mode.
>>and the shifted command line should be fixed then.
>>
>>Thanks,
>>Kirill
>>
>>
>>>>Hi list,
>>>>
>>>>Patch removing logmessage "Open /dev/pts/X"
>>>
>>>>from src/enter.c when entering VE
>>>
>>>>Before:
>>>># vzctl enter 1010
>>>>entered into VE 1010
>>>>Open /dev/pts/0
>>>> root@dev-test2:/#
>>>>
>>>>After:
>>>># vzctl enter 1010
>>>>entered into VE 1010
>>>>root@dev-test2:/#
>>>
>>>This is useful debug message, why to remove it?
>>>If the problem is that the next line is shifted, then we need another
>>>fix.
>>>
>>>
>>>>Best regards,
>>>>Kristian Høgh
>>>>Segtel A/S
>>
Re: Remove logmessage when entering VE [message #7290 is a reply to message #7275] Tue, 10 October 2006 09:40 Go to previous messageGo to next message
kfh is currently offline  kfh
Messages: 28
Registered: October 2006
Junior Member
On Monday den 9. October 2006 19:03, Kirill Korotaev wrote:

> > I want information in my logfile, but a quiet console.

> Mmm, I can't see many usecases... can you describe how you use it?
> usually higher log levels are needed for debugging only...

I don't think loglevel should make any difference for console output.
I don't think --verbose should make any difference for logfile loglevel.

As I would like it:
I would like level 2 log in my logfile and "none" on the console.
If I have a problem I would use --verbose on the cmd-line to raise
level on console or look in the logfile.

Logfile on start: (this is the same as standard loglevel 2)
VE 1010 : Starting VE ...
VE 1010 : Mounting root: /var/.../root/1010 /var/.../private/vz20061009
VE 1010 : Running: /etc/vz//conf/vps.mount
VE 1010 : VE is mounted
VE 1010 : Running VE script: /etc/vz/dists/scripts/none
VE 1010 : Setting CPU limit: 50
VE 1010 : Setting CPU units: 1000
VE 1010 : Configure meminfo: 10240
VE 1010 : Set hostname: vs1010
VE 1010 : Running VE script: /etc/vz/dists/scripts/none
VE 1010 : Configure veth devices: ve1010.0
VE 1010 : Running: /usr/sbin/vznetcfg init veth ve1010.0
VE 1010 : VE start in progress...

Today (standard level 0)
# vzctl start 1010
Starting VE ...
VE is mounted
Setting CPU limit: 50 (--verbose)
Setting CPU units: 1000 (--verbose)
Configure meminfo: 10240 (--verbose)
Set hostname: vs1010
Configure veth devices: ve1010.0
VE start in progress...

As I would like it (loglevel should not matter):
# vzctl start 1010
Starting VE ...
VE is mounted
Set hostname: vs1010 (maybe --verbose)
Configure veth devices: ve1010.0 (maybe --verbose)
VE start in progress...

(--verbose, same as today)
# vzctl --verbose start 1010
Unable to open /usr/lib/vzctl/modules/: No such file or directory
Starting VE ...
Mounting root: /var/.../root/1010 /var/.../private/vz20061009
Running: /etc/vz//conf/vps.mount
VE is mounted
Running VE script: /etc/vz/dists/scripts/none
Setting CPU limit: 50
Setting CPU units: 1000
Configure meminfo: 10240
Set hostname: vs1010
Running VE script: /etc/vz/dists/scripts/none
Configure veth devices: ve1010.0
Running: /usr/sbin/vznetcfg init veth ve1010.0
VE start in progress...

Then I could have:
# vzctl enter 1010
entered into VE 1010
root@dev-test2:/#

# vzctl --verbose enter 1010
entered into VE 1010
Open /dev/pts/0
root@dev-test2:/#


> I suppose CONSOLE_LEVEL option can be added.
Don't think it's needed.

> Care to make a patch?
Maybe. If you like the above, and give me some pointers.
--quiet is a little to quiet :-)

> Thanks,
> Kirill

Regards,
Kristian.
Re: Remove logmessage when entering VE [message #7293 is a reply to message #7290] Tue, 10 October 2006 12:42 Go to previous message
dev is currently offline  dev
Messages: 1693
Registered: September 2005
Location: Moscow
Senior Member

Kristian,

your comment looks quite reasonable.
a) --quite and --verbose affect console output only.
b) LOGLEVEL to affect log file output.

Sounds fine.

Thanks,
Kirill

> On Monday den 9. October 2006 19:03, Kirill Korotaev wrote:
>
>
>>>I want information in my logfile, but a quiet console.
>
>
>>Mmm, I can't see many usecases... can you describe how you use it?
>>usually higher log levels are needed for debugging only...
>
>
> I don't think loglevel should make any difference for console output.
> I don't think --verbose should make any difference for logfile loglevel.
>
> As I would like it:
> I would like level 2 log in my logfile and "none" on the console.
> If I have a problem I would use --verbose on the cmd-line to raise
> level on console or look in the logfile.
>
> Logfile on start: (this is the same as standard loglevel 2)
> VE 1010 : Starting VE ...
> VE 1010 : Mounting root: /var/.../root/1010 /var/.../private/vz20061009
> VE 1010 : Running: /etc/vz//conf/vps.mount
> VE 1010 : VE is mounted
> VE 1010 : Running VE script: /etc/vz/dists/scripts/none
> VE 1010 : Setting CPU limit: 50
> VE 1010 : Setting CPU units: 1000
> VE 1010 : Configure meminfo: 10240
> VE 1010 : Set hostname: vs1010
> VE 1010 : Running VE script: /etc/vz/dists/scripts/none
> VE 1010 : Configure veth devices: ve1010.0
> VE 1010 : Running: /usr/sbin/vznetcfg init veth ve1010.0
> VE 1010 : VE start in progress...
>
> Today (standard level 0)
> # vzctl start 1010
> Starting VE ...
> VE is mounted
> Setting CPU limit: 50 (--verbose)
> Setting CPU units: 1000 (--verbose)
> Configure meminfo: 10240 (--verbose)
> Set hostname: vs1010
> Configure veth devices: ve1010.0
> VE start in progress...
>
> As I would like it (loglevel should not matter):
> # vzctl start 1010
> Starting VE ...
> VE is mounted
> Set hostname: vs1010 (maybe --verbose)
> Configure veth devices: ve1010.0 (maybe --verbose)
> VE start in progress...
>
> (--verbose, same as today)
> # vzctl --verbose start 1010
> Unable to open /usr/lib/vzctl/modules/: No such file or directory
> Starting VE ...
> Mounting root: /var/.../root/1010 /var/.../private/vz20061009
> Running: /etc/vz//conf/vps.mount
> VE is mounted
> Running VE script: /etc/vz/dists/scripts/none
> Setting CPU limit: 50
> Setting CPU units: 1000
> Configure meminfo: 10240
> Set hostname: vs1010
> Running VE script: /etc/vz/dists/scripts/none
> Configure veth devices: ve1010.0
> Running: /usr/sbin/vznetcfg init veth ve1010.0
> VE start in progress...
>
> Then I could have:
> # vzctl enter 1010
> entered into VE 1010
> root@dev-test2:/#
>
> # vzctl --verbose enter 1010
> entered into VE 1010
> Open /dev/pts/0
> root@dev-test2:/#
>
>
>
>>I suppose CONSOLE_LEVEL option can be added.
>
> Don't think it's needed.
>
>
>>Care to make a patch?
>
> Maybe. If you like the above, and give me some pointers.
> --quiet is a little to quiet :-)
>
>
>>Thanks,
>>Kirill
>
>
> Regards,
> Kristian.
>
Previous Topic: Add veid argument to vznetcfg
Next Topic: [PATCH] block layer: elv_iosched_show should get elv_list_lock
Goto Forum:
  


Current Time: Mon Jul 15 08:53:26 GMT 2024

Total time taken to generate the page: 0.02368 seconds