OpenVZ Forum: Devel » Re: [RFC][PATCH] Add child reaper to struct pspace

Home » Mailing lists » Devel » Re: [RFC][PATCH] Add child reaper to struct pspace

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [RFC][PATCH] Add child reaper to struct pspace [message #6128]

Fri, 08 September 2006 17:32

dev
Messages: 1693
Registered: September 2005
Location: Moscow

Senior Member

Sukadev Bhattiprolu wrote:
> Cedric Le Goater [clg@fr.ibm.com] wrote:
> |
> | <snip>
> |
> | > */
> | > static void
> | > forget_original_parent(struct task_struct *father, struct list_head *to_release)
> | > @@ -669,7 +670,7 @@ forget_original_parent(struct task_struc
> | > do {
> | > reaper = next_thread(reaper);
> | > if (reaper == father) {
> | > - reaper = child_reaper;
> | > + reaper = father->pspace->child_reaper;
> | > break;
> | > }
> | > } while (reaper->exit_state);
> | > @@ -857,7 +858,7 @@ fastcall NORET_TYPE void do_exit(long co
> |
> | what about killing all the task in that pid space if child_reaper == init
> | dies ?
> |
>
> We probably need that for instance when a process in the parent pspace
> kills the init of a child pspace, we should destroy the child pspace
> by killing all the tasks in the child pspace including the child reaper.
exactly. the situation you described is how we do handle it.
you can check do_initproc_exit() function in OpenVZ
to check how it can be done and probably save some of your time.
(http://git.openvz.org/?p=linux-2.6-openvz;a=summary)

> I guess we need to maintain a list of task_structs in the pspace and walk
> that list. Will work on that as a separate patch.
wait. we either need to have a list of _pids_ or it
should be called task_namespace, not pid, since we are adding more
code related to tasks.

Kirill

Report message to a moderator

[Message index]

		Re: [RFC][PATCH] Add child reaper to struct pspace By: dev on Fri, 08 September 2006 17:32
		Re: [RFC][PATCH] Add child reaper to struct pspace By: ebiederm on Sat, 09 September 2006 04:54
		Re: [RFC][PATCH] Add child reaper to struct pspace By: dev on Tue, 12 September 2006 14:41
		Re: [RFC][PATCH] Add child reaper to struct pspace By: ebiederm on Tue, 12 September 2006 15:43
		Re: [RFC][PATCH] Add child reaper to struct pspace By: dev on Sat, 16 September 2006 11:55

Previous Topic:	[Patch05/05]: Containers: Over the memory limit handler
Next Topic:	Re: [RFC][PATCH 1/2] add user namespace [try #2]

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Mon Aug 31 18:45:05 GMT 2026

Total time taken to generate the page: 0.51419 seconds