OpenVZ Forum: Devel » Re: Re: [RFC][PATCH] Rename pspace to pid

Home » Mailing lists » Devel » Re: Re: [RFC][PATCH] Rename pspace to pid_namespace

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: Re: [RFC][PATCH] Rename pspace to pid_namespace [message #6108]

Fri, 08 September 2006 10:13

Cedric Le Goater
Messages: 443
Registered: February 2006

Senior Member

Eric W. Biederman wrote:
> Sukadev Bhattiprolu <sukadev@us.ibm.com> writes:
>
>> Rename struct pspace to struct pid_namespace for consistency with
>> other namespaces (uts_namespace and ipc_namespace). Also rename
>> include/linux/pspace.h to include/linux/pid_namespace.h and variables
>> from pspace to pid_ns.
>
> This fails to fixup next_pidmap, which was added recently.
>
> It turned out that readdir on /proc was iterating through processes
> in a completely broken way, so it needed to be changed to iterate
> through processes in pid order.

That's a pending patch for next -mm, right ?

C.

Report message to a moderator

Re: Re: [RFC][PATCH] Rename pspace to pid_namespace [message #6110 is a reply to message #6108]

Fri, 08 September 2006 11:30

ebiederm
Messages: 1354
Registered: February 2006

Senior Member

Cedric Le Goater <clg@fr.ibm.com> writes:

> Eric W. Biederman wrote:
>> Sukadev Bhattiprolu <sukadev@us.ibm.com> writes:
>>
>>> Rename struct pspace to struct pid_namespace for consistency with
>>> other namespaces (uts_namespace and ipc_namespace). Also rename
>>> include/linux/pspace.h to include/linux/pid_namespace.h and variables
>>> from pspace to pid_ns.
>>
>> This fails to fixup next_pidmap, which was added recently.
>>
>> It turned out that readdir on /proc was iterating through processes
>> in a completely broken way, so it needed to be changed to iterate
>> through processes in pid order.
>
> That's a pending patch for next -mm, right ?

I was about to say yes. But Andrew just released 2.6.18-rc6-mm1
So it isn't pending anymore.

Eric

Report message to a moderator

Re: Re: [RFC][PATCH] Rename pspace to pid_namespace [message #6115 is a reply to message #6110]

Fri, 08 September 2006 13:19

Cedric Le Goater
Messages: 443
Registered: February 2006

Senior Member

Eric W. Biederman wrote:
> Cedric Le Goater <clg@fr.ibm.com> writes:
>
>> Eric W. Biederman wrote:
>>> Sukadev Bhattiprolu <sukadev@us.ibm.com> writes:
>>>
>>>> Rename struct pspace to struct pid_namespace for consistency with
>>>> other namespaces (uts_namespace and ipc_namespace). Also rename
>>>> include/linux/pspace.h to include/linux/pid_namespace.h and variables
>>>> from pspace to pid_ns.
>>> This fails to fixup next_pidmap, which was added recently.
>>>
>>> It turned out that readdir on /proc was iterating through processes
>>> in a completely broken way, so it needed to be changed to iterate
>>> through processes in pid order.
>> That's a pending patch for next -mm, right ?
>
> I was about to say yes. But Andrew just released 2.6.18-rc6-mm1
> So it isn't pending anymore.

ok. I will port the patchset on the new -mm and include next_pidmap.

thanks,

C.

Report message to a moderator

Previous Topic:	[PATCH] fail kernel compilation in case of unresolved symbols (v2)
Next Topic:	[RFC][PATCH] Add child reaper to struct pspace

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Wed Nov 26 14:00:03 GMT 2025

Total time taken to generate the page: 0.59898 seconds