Re: [PATCH 1/7] introduce atomic_dec_and_lock_irqsave() [message #5796 is a reply to message #5771] |
Wed, 30 August 2006 16:58 |
Dipankar Sarma
Messages: 1 Registered: August 2006
|
Junior Member |
|
|
On Wed, Aug 30, 2006 at 12:51:28PM +0200, Roman Zippel wrote:
> Hi,
>
> On Wed, 30 Aug 2006, Oleg Nesterov wrote:
>
> > > Why does this need protection against interrupts?
> >
> > uidhash_lock can be taken from irq context. For example, delayed_put_task_struct()
> > does __put_task_struct()->free_uid().
>
> AFAICT it's called via rcu, does that mean anything released via rcu has
> to be protected against interrupts?
No. You need protection only if you have are using some
data that can also be used by the RCU callback. For example,
if your RCU callback just calls kfree(), you don't have to
do a spin_lock_bh().
Thanks
Dipankar
|
|
|