OpenVZ Forum: Devel » [PATCH v5 00/14] kmem controller for memcg.

Home » Mailing lists » Devel » [PATCH v5 00/14] kmem controller for memcg.

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH v5 06/14] memcg: kmem controller infrastructure [message #48502 is a reply to message #48462]

Thu, 18 October 2012 21:59

David Rientjes
Messages: 59
Registered: November 2006

Member

On Thu, 18 Oct 2012, Glauber Costa wrote:

> >> @@ -2630,6 +2634,171 @@ static void __mem_cgroup_commit_charge(struct mem_cgroup *memcg,
> >> memcg_check_events(memcg, page);
> >> }
> >>
> >> +#ifdef CONFIG_MEMCG_KMEM
> >> +static inline bool memcg_can_account_kmem(struct mem_cgroup *memcg)
> >> +{
> >> + return !mem_cgroup_disabled() && !mem_cgroup_is_root(memcg) &&
> >> + (memcg->kmem_accounted & KMEM_ACCOUNTED_MASK);
> >> +}
> >> +
> >> +static int memcg_charge_kmem(struct mem_cgroup *memcg, gfp_t gfp, u64 size)
> >> +{
> >> + struct res_counter *fail_res;
> >> + struct mem_cgroup *_memcg;
> >> + int ret = 0;
> >> + bool may_oom;
> >> +
> >> + ret = res_counter_charge(&memcg->kmem, size, &fail_res);
> >> + if (ret)
> >> + return ret;
> >> +
> >> + /*
> >> + * Conditions under which we can wait for the oom_killer.
> >> + * We have to be able to wait, but also, if we can't retry,
> >> + * we obviously shouldn't go mess with oom.
> >> + */
> >> + may_oom = (gfp & __GFP_WAIT) && !(gfp & __GFP_NORETRY);
> >
> > What about gfp & __GFP_FS?
> >
>
> Do you intend to prevent or allow OOM under that flag? I personally
> think that anything that accepts to be OOM-killed should have GFP_WAIT
> set, so that ought to be enough.
>

The oom killer in the page allocator cannot trigger without __GFP_FS
because direct reclaim has little chance of being very successful and
thus we end up needlessly killing processes, and that tends to happen
quite a bit if we dont check for it. Seems like this would also happen
with memcg if mem_cgroup_reclaim() has a large probability of failing?

Report message to a moderator

[Message index]

		[PATCH v5 00/14] kmem controller for memcg. By: Glauber Costa on Tue, 16 October 2012 10:16
		[PATCH v5 03/14] memcg: change defines to an enum By: Glauber Costa on Tue, 16 October 2012 10:16
		Re: [PATCH v5 03/14] memcg: change defines to an enum By: David Rientjes on Wed, 17 October 2012 21:50
		[PATCH v5 01/14] memcg: Make it possible to use the stock for more than one page. By: Glauber Costa on Tue, 16 October 2012 10:16
		Re: [PATCH v5 01/14] memcg: Make it possible to use the stock for more than one page. By: akpm on Wed, 17 October 2012 22:11
		Re: [PATCH v5 01/14] memcg: Make it possible to use the stock for more than one page. By: Glauber Costa on Thu, 18 October 2012 08:55
		[PATCH v5 04/14] kmem accounting basic infrastructure By: Glauber Costa on Tue, 16 October 2012 10:16
		Re: [PATCH v5 04/14] kmem accounting basic infrastructure By: Michal Hocko on Tue, 16 October 2012 12:14
		Re: [PATCH v5 04/14] kmem accounting basic infrastructure By: David Rientjes on Wed, 17 October 2012 22:08
		Re: [PATCH v5 04/14] kmem accounting basic infrastructure By: Glauber Costa on Thu, 18 October 2012 09:02
		Re: [PATCH v5 04/14] kmem accounting basic infrastructure By: Tejun Heo on Thu, 18 October 2012 19:47
		Re: [PATCH v5 04/14] kmem accounting basic infrastructure By: Tejun Heo on Thu, 18 October 2012 19:37
		Re: [PATCH v5 04/14] kmem accounting basic infrastructure By: akpm on Wed, 17 October 2012 22:12
		Re: [PATCH v5 04/14] kmem accounting basic infrastructure By: Glauber Costa on Thu, 18 October 2012 09:04
		[PATCH v5 11/14] memcg: allow a memcg with kmem charges to be destructed. By: Glauber Costa on Tue, 16 October 2012 10:16
		Re: [PATCH v5 11/14] memcg: allow a memcg with kmem charges to be destructed. By: akpm on Wed, 17 October 2012 22:12
		Re: [PATCH v5 11/14] memcg: allow a memcg with kmem charges to be destructed. By: Glauber Costa on Thu, 18 October 2012 09:33
		[PATCH v5 06/14] memcg: kmem controller infrastructure By: Glauber Costa on Tue, 16 October 2012 10:16
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: KAMEZAWA Hiroyuki on Wed, 17 October 2012 06:40
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: akpm on Wed, 17 October 2012 22:12
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: Glauber Costa on Thu, 18 October 2012 09:16
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: David Rientjes on Thu, 18 October 2012 22:06
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: Glauber Costa on Fri, 19 October 2012 09:10
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: David Rientjes on Fri, 19 October 2012 09:31
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: Glauber Costa on Fri, 19 October 2012 10:00
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: David Rientjes on Wed, 17 October 2012 22:37
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: Glauber Costa on Thu, 18 October 2012 09:23
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: David Rientjes on Thu, 18 October 2012 21:59
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: Glauber Costa on Fri, 19 October 2012 10:08
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: David Rientjes on Fri, 19 October 2012 20:34
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: Glauber Costa on Mon, 22 October 2012 12:34
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: Michal Hocko on Mon, 22 October 2012 12:51
		Re: [PATCH v5 06/14] memcg: kmem controller infrastructure By: Glauber Costa on Mon, 22 October 2012 12:52
		[PATCH v5 05/14] Add a __GFP_KMEMCG flag By: Glauber Costa on Tue, 16 October 2012 10:16
		Re: [PATCH v5 05/14] Add a __GFP_KMEMCG flag By: Michal Hocko on Tue, 16 October 2012 12:15
		Re: [PATCH v5 05/14] Add a __GFP_KMEMCG flag By: David Rientjes on Wed, 17 October 2012 22:09
		[PATCH v5 09/14] memcg: kmem accounting lifecycle management By: Glauber Costa on Tue, 16 October 2012 10:16
		Re: [PATCH v5 09/14] memcg: kmem accounting lifecycle management By: David Rientjes on Wed, 17 October 2012 23:28
		Re: [PATCH v5 09/14] memcg: kmem accounting lifecycle management By: Michal Hocko on Thu, 18 October 2012 06:14
		Re: [PATCH v5 09/14] memcg: kmem accounting lifecycle management By: Glauber Costa on Thu, 18 October 2012 09:42
		[PATCH v5 10/14] memcg: use static branches when code not in use By: Glauber Costa on Tue, 16 October 2012 10:16
		[PATCH v5 14/14] Add documentation about the kmem controller By: Glauber Costa on Tue, 16 October 2012 10:16
		Re: [PATCH v5 14/14] Add documentation about the kmem controller By: Michal Hocko on Tue, 16 October 2012 12:23
		Re: [PATCH v5 14/14] Add documentation about the kmem controller By: Christoph Lameter on Tue, 16 October 2012 18:25
		Re: [PATCH v5 14/14] Add documentation about the kmem controller By: Glauber Costa on Tue, 16 October 2012 19:02
		Re: [PATCH v5 14/14] Add documentation about the kmem controller By: Christoph Lameter on Tue, 16 October 2012 19:30
		Re: [PATCH v5 14/14] Add documentation about the kmem controller By: akpm on Wed, 17 October 2012 22:12
		Re: [PATCH v5 14/14] Add documentation about the kmem controller By: Glauber Costa on Thu, 18 October 2012 09:38
		[PATCH v5 13/14] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs By: Glauber Costa on Tue, 16 October 2012 10:16
		Re: [PATCH v5 13/14] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs By: akpm on Wed, 17 October 2012 22:12
		Re: [PATCH v5 13/14] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs By: Glauber Costa on Thu, 18 October 2012 09:37
		[PATCH v5 07/14] mm: Allocate kernel pages to the right memcg By: Glauber Costa on Tue, 16 October 2012 10:16
		Re: [PATCH v5 07/14] mm: Allocate kernel pages to the right memcg By: Christoph Lameter on Tue, 16 October 2012 15:31
		Re: [PATCH v5 07/14] mm: Allocate kernel pages to the right memcg By: Glauber Costa on Tue, 16 October 2012 18:55
		Re: [PATCH v5 07/14] mm: Allocate kernel pages to the right memcg By: akpm on Wed, 17 October 2012 22:12
		Re: [PATCH v5 07/14] mm: Allocate kernel pages to the right memcg By: Glauber Costa on Thu, 18 October 2012 09:24
		Re: [PATCH v5 07/14] mm: Allocate kernel pages to the right memcg By: akpm on Thu, 18 October 2012 20:44
		Re: [PATCH v5 07/14] mm: Allocate kernel pages to the right memcg By: Glauber Costa on Thu, 18 October 2012 11:53
		Re: [PATCH v5 07/14] mm: Allocate kernel pages to the right memcg By: David Rientjes on Wed, 17 October 2012 22:43
		Re: [PATCH v5 00/14] kmem controller for memcg. By: akpm on Wed, 17 October 2012 22:11
		Re: [PATCH v5 00/14] kmem controller for memcg. By: Glauber Costa on Thu, 18 October 2012 08:52
		Re: [PATCH v5 00/14] kmem controller for memcg. By: akpm on Thu, 18 October 2012 19:21
		Re: [PATCH v5 00/14] kmem controller for memcg. By: Glauber Costa on Fri, 19 October 2012 09:55

Previous Topic:	[PATCH RFC] sched: boost throttled entities on wakeups
Next Topic:	[PATCH v6 01/10] ipc: remove forced assignment of selected message

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Mon Aug 25 15:26:56 GMT 2025

Total time taken to generate the page: 0.05942 seconds