| Re: [PATCH v7 00/10] IPC: checkpoint/restore in userspace enhancements [message #48495 is a reply to message #48476] |
Thu, 18 October 2012 12:11  |
ebiederm
Messages: 1354
Registered: February 2006
|
Senior Member |
|
|
Nacked-by: "Eric W. Biederman" <ebiederm@xmission.com>
You ignored all of my feedback that the first 7 messages of your
patchset are unnecessary. In particular you did not attempt to focus
your patchset on those operations that are most important.
Upon examination it appears also that the 8th and 9th patches of the
patchset are also unnecessary. And the 10th patch is just a test of the
previous patches, making the 10th patch unneceesary without the rest.
In net this entire patchset is unnecessary and a waste of your reviewers
time.
Once you have IPC checkpoint and restore working there may be a point to
come back and optimize things. Please don't come back with any System V
Interprocess Communication patches until you can report how much time
is saved by each and every change.
Eric
|
|
|
|
OpenVZ Forum
Members
Search
Help
Register
Login
Home
