| Re: [PATCH v6 04/10] ipc: add new SHM_SET command for sys_shmctl() call [message #48376 is a reply to message #48338] |
Tue, 16 October 2012 07:55   |
Stanislav Kinsbursky
Messages: 683
Registered: October 2011
|
Senior Member |
|
|
15.10.2012 23:00, Ben Hutchings пишет:
> On Mon, 2012-10-15 at 19:59 +0400, Stanislav Kinsbursky wrote:
>> New SHM_SET command will be interpreted exactly as IPC_SET, but also will
>> update key, cuid and cgid values. IOW, it allows to change existent key value.
>> The fact, that key is not used is checked before update. Otherwise -EEXIST is
>> returned.
> [...]
>> --- a/ipc/shm.c
>> +++ b/ipc/shm.c
> [...]
>> @@ -759,6 +763,10 @@ static int shmctl_down(struct ipc_namespace *ns, int shmid, int cmd,
>> case IPC_RMID:
>> do_shm_rmid(ns, ipcp);
>> goto out_up;
>> + case SHM_SET:
>> + err = ipc_update_key(&shm_ids(ns), &shmid64.shm_perm, ipcp);
>> + if (err)
>> + break;
> [...]
>
> Please add /* fall through */ here, and in the similar cases in patches
> 5 and 7, to make clear that it's deliberate.
>
Sure, thanks.
> Ben.
>
--
Best regards,
Stanislav Kinsbursky
|
|
|
|
OpenVZ Forum
Members
Search
Help
Register
Login
Home
