OpenVZ Forum: Devel » [PATCH 00/11] kmem controller for memcg: stripped down version

Home » Mailing lists » Devel » [PATCH 00/11] kmem controller for memcg: stripped down version

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

[PATCH 10/11] memcg: allow a memcg with kmem charges to be destructed. [message #46922 is a reply to message #46916]

Mon, 25 June 2012 14:15

Glauber Costa
Messages: 916
Registered: October 2011

Senior Member

Because the ultimate goal of the kmem tracking in memcg is to
track slab pages as well, we can't guarantee that we'll always
be able to point a page to a particular process, and migrate
the charges along with it - since in the common case, a page
will contain data belonging to multiple processes.

Because of that, when we destroy a memcg, we only make sure
the destruction will succeed by discounting the kmem charges
from the user charges when we try to empty the cgroup.

Signed-off-by: Glauber Costa <glommer@parallels.com>
CC: Christoph Lameter <cl@linux.com>
CC: Pekka Enberg <penberg@cs.helsinki.fi>
CC: Michal Hocko <mhocko@suse.cz>
CC: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
CC: Johannes Weiner <hannes@cmpxchg.org>
CC: Suleiman Souhlal <suleiman@google.com>
---
mm/memcontrol.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index a6a440b..bb9b6fe 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -598,6 +598,11 @@ static void disarm_kmem_keys(struct mem_cgroup *memcg)
{
if (test_bit(KMEM_ACCOUNTED_THIS, &memcg->kmem_accounted))
static_key_slow_dec(&mem_cgroup_kmem_enabled_key);
+ /*
+ * This check can't live in kmem destruction function,
+ * since the charges will outlive the cgroup
+ */
+ BUG_ON(res_counter_read_u64(&memcg->kmem, RES_USAGE) != 0);
}
#else
static void disarm_kmem_keys(struct mem_cgroup *memcg)
@@ -3838,6 +3843,7 @@ static int mem_cgroup_force_empty(struct mem_cgroup *memcg, bool free_all)
int node, zid, shrink;
int nr_retries = MEM_CGROUP_RECLAIM_RETRIES;
struct cgroup *cgrp = memcg->css.cgroup;
+ u64 usage;

css_get(&memcg->css);

@@ -3877,8 +3883,10 @@ move_account:
if (ret == -ENOMEM)
goto try_to_free;
cond_resched();
+ usage = res_counter_read_u64(&memcg->res, RES_USAGE) -
+ res_counter_read_u64(&memcg->kmem, RES_USAGE);
/* "ret" should also be checked to ensure all lists are empty. */
- } while (res_counter_read_u64(&memcg->res, RES_USAGE) > 0 || ret);
+ } while (usage > 0 || ret);
out:
css_put(&memcg->css);
return ret;
--
1.7.10.2

Report message to a moderator

[Message index]

		[PATCH 00/11] kmem controller for memcg: stripped down version By: Glauber Costa on Mon, 25 June 2012 14:15
		[PATCH 02/11] memcg: Reclaim when more than one page needed. By: Glauber Costa on Mon, 25 June 2012 14:15
		Re: [PATCH 02/11] memcg: Reclaim when more than one page needed. By: Suleiman Souhlal on Mon, 25 June 2012 23:33
		Re: [PATCH 02/11] memcg: Reclaim when more than one page needed. By: Glauber Costa on Tue, 26 June 2012 08:39
		Re: [PATCH 02/11] memcg: Reclaim when more than one page needed. By: Suleiman Souhlal on Wed, 27 June 2012 16:16
		Re: [PATCH 02/11] memcg: Reclaim when more than one page needed. By: David Rientjes on Tue, 26 June 2012 04:09
		Re: [PATCH 02/11] memcg: Reclaim when more than one page needed. By: Glauber Costa on Tue, 26 June 2012 07:12
		Re: [PATCH 02/11] memcg: Reclaim when more than one page needed. By: David Rientjes on Tue, 26 June 2012 08:54
		Re: [PATCH 02/11] memcg: Reclaim when more than one page needed. By: Glauber Costa on Tue, 26 June 2012 09:08
		Re: [PATCH 02/11] memcg: Reclaim when more than one page needed. By: David Rientjes on Tue, 26 June 2012 09:17
		Re: [PATCH 02/11] memcg: Reclaim when more than one page needed. By: Glauber Costa on Tue, 26 June 2012 09:23
		Re: [PATCH 02/11] memcg: Reclaim when more than one page needed. By: Glauber Costa on Wed, 27 June 2012 10:03
		Re: [PATCH 02/11] memcg: Reclaim when more than one page needed. By: David Rientjes on Wed, 27 June 2012 19:48
		Re: [PATCH 02/11] memcg: Reclaim when more than one page needed. By: Glauber Costa on Wed, 27 June 2012 20:47
		[PATCH 03/11] memcg: change defines to an enum By: Glauber Costa on Mon, 25 June 2012 14:15
		Re: [PATCH 03/11] memcg: change defines to an enum By: David Rientjes on Tue, 26 June 2012 04:11
		Re: [PATCH 03/11] memcg: change defines to an enum By: Glauber Costa on Tue, 26 June 2012 08:28
		Re: [PATCH 03/11] memcg: change defines to an enum By: David Rientjes on Tue, 26 June 2012 09:01
		[PATCH 01/11] memcg: Make it possible to use the stock for more than one page. By: Glauber Costa on Mon, 25 June 2012 14:15
		Re: [PATCH 01/11] memcg: Make it possible to use the stock for more than one page. By: Tejun Heo on Mon, 25 June 2012 17:44
		Re: [PATCH 01/11] memcg: Make it possible to use the stock for more than one page. By: Glauber Costa on Mon, 25 June 2012 22:29
		Re: [PATCH 01/11] memcg: Make it possible to use the stock for more than one page. By: Tejun Heo on Mon, 25 June 2012 22:33
		Re: [PATCH 01/11] memcg: Make it possible to use the stock for more than one page. By: David Rientjes on Tue, 26 June 2012 04:01
		[PATCH 05/11] Add a __GFP_KMEMCG flag By: Glauber Costa on Mon, 25 June 2012 14:15
		Re: [PATCH 05/11] Add a __GFP_KMEMCG flag By: David Rientjes on Tue, 26 June 2012 04:25
		Re: [PATCH 05/11] Add a __GFP_KMEMCG flag By: Glauber Costa on Tue, 26 June 2012 07:08
		Re: [PATCH 05/11] Add a __GFP_KMEMCG flag By: David Rientjes on Tue, 26 June 2012 09:03
		[PATCH 04/11] kmem slab accounting basic infrastructure By: Glauber Costa on Mon, 25 June 2012 14:15
		Re: [PATCH 04/11] kmem slab accounting basic infrastructure By: David Rientjes on Tue, 26 June 2012 04:22
		Re: [PATCH 04/11] kmem slab accounting basic infrastructure By: Glauber Costa on Tue, 26 June 2012 07:09
		[PATCH 10/11] memcg: allow a memcg with kmem charges to be destructed. By: Glauber Costa on Mon, 25 June 2012 14:15
		Re: [PATCH 10/11] memcg: allow a memcg with kmem charges to be destructed. By: Tejun Heo on Mon, 25 June 2012 18:34
		Re: [PATCH 10/11] memcg: allow a memcg with kmem charges to be destructed. By: Glauber Costa on Mon, 25 June 2012 22:25
		Re: [PATCH 10/11] memcg: allow a memcg with kmem charges to be destructed. By: KAMEZAWA Hiroyuki on Tue, 26 June 2012 05:59
		Re: [PATCH 10/11] memcg: allow a memcg with kmem charges to be destructed. By: Glauber Costa on Tue, 26 June 2012 07:21
		[PATCH 07/11] mm: Allocate kernel pages to the right memcg By: Glauber Costa on Mon, 25 June 2012 14:15
		Re: [PATCH 07/11] mm: Allocate kernel pages to the right memcg By: Tejun Heo on Mon, 25 June 2012 18:07
		Re: [PATCH 07/11] mm: Allocate kernel pages to the right memcg By: Glauber Costa on Mon, 25 June 2012 22:27
		[PATCH 11/11] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs By: Glauber Costa on Mon, 25 June 2012 14:15
		Re: [PATCH 11/11] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs By: Tejun Heo on Mon, 25 June 2012 18:38
		Re: [PATCH 11/11] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs By: Frederic Weisbecker on Mon, 25 June 2012 20:57
		Re: [PATCH 11/11] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs By: Glauber Costa on Tue, 26 June 2012 12:48
		Re: [PATCH 11/11] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs By: Frederic Weisbecker on Tue, 26 June 2012 13:38
		Re: [PATCH 11/11] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs By: Glauber Costa on Tue, 26 June 2012 13:37
		Re: [PATCH 11/11] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs By: Frederic Weisbecker on Tue, 26 June 2012 13:44
		Re: [PATCH 11/11] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs By: David Rientjes on Tue, 26 June 2012 04:57
		Re: [PATCH 11/11] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs By: KAMEZAWA Hiroyuki on Tue, 26 June 2012 05:35
		Re: [PATCH 11/11] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs By: Glauber Costa on Tue, 26 June 2012 07:23
		Re: [PATCH 11/11] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs By: David Rientjes on Tue, 26 June 2012 08:45
		Re: [PATCH 11/11] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs By: Glauber Costa on Tue, 26 June 2012 08:44
		Re: [PATCH 11/11] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs By: David Rientjes on Tue, 26 June 2012 09:05
		Re: [PATCH 11/11] protect architectures where THREAD_SIZE >= PAGE_SIZE against fork bombs By: Frederic Weisbecker on Mon, 25 June 2012 16:55
		[PATCH 06/11] memcg: kmem controller infrastructure By: Glauber Costa on Mon, 25 June 2012 14:15
		Re: [PATCH 06/11] memcg: kmem controller infrastructure By: Tejun Heo on Mon, 25 June 2012 18:06
		Re: [PATCH 06/11] memcg: kmem controller infrastructure By: Glauber Costa on Mon, 25 June 2012 22:28
		Re: [PATCH 06/11] memcg: kmem controller infrastructure By: akpm on Mon, 25 June 2012 23:17
		Re: [PATCH 06/11] memcg: kmem controller infrastructure By: Glauber Costa on Tue, 26 June 2012 14:40
		Re: [PATCH 06/11] memcg: kmem controller infrastructure By: Glauber Costa on Tue, 26 June 2012 15:01
		Re: [PATCH 06/11] memcg: kmem controller infrastructure By: akpm on Tue, 26 June 2012 18:01
		Re: [PATCH 06/11] memcg: kmem controller infrastructure By: Tejun Heo on Tue, 26 June 2012 18:08
		Re: [PATCH 06/11] memcg: kmem controller infrastructure By: Glauber Costa on Tue, 26 June 2012 18:14
		Re: [PATCH 06/11] memcg: kmem controller infrastructure By: akpm on Tue, 26 June 2012 19:20
		Re: [PATCH 06/11] memcg: kmem controller infrastructure By: Glauber Costa on Tue, 26 June 2012 15:29
		Re: [PATCH 06/11] memcg: kmem controller infrastructure By: David Rientjes on Tue, 26 June 2012 09:12
		Re: [PATCH 06/11] memcg: kmem controller infrastructure By: Glauber Costa on Tue, 26 June 2012 09:17
		Re: [PATCH 06/11] memcg: kmem controller infrastructure By: David Rientjes on Wed, 27 June 2012 04:01
		Re: [PATCH 06/11] memcg: kmem controller infrastructure By: Glauber Costa on Wed, 27 June 2012 09:33
		Re: [PATCH 06/11] memcg: kmem controller infrastructure By: David Rientjes on Wed, 27 June 2012 19:46
		[PATCH 09/11] memcg: propagate kmem limiting information to children By: Glauber Costa on Mon, 25 June 2012 14:15
		Re: [PATCH 09/11] memcg: propagate kmem limiting information to children By: Tejun Heo on Mon, 25 June 2012 18:29
		Re: [PATCH 09/11] memcg: propagate kmem limiting information to children By: Glauber Costa on Mon, 25 June 2012 22:36
		Re: [PATCH 09/11] memcg: propagate kmem limiting information to children By: Tejun Heo on Mon, 25 June 2012 22:49
		Re: [PATCH 09/11] memcg: propagate kmem limiting information to children By: akpm on Mon, 25 June 2012 23:21
		Re: [PATCH 09/11] memcg: propagate kmem limiting information to children By: David Rientjes on Tue, 26 June 2012 05:23
		Re: [PATCH 09/11] memcg: propagate kmem limiting information to children By: akpm on Mon, 25 June 2012 23:23
		Re: [PATCH 09/11] memcg: propagate kmem limiting information to children By: David Rientjes on Tue, 26 June 2012 05:24
		Re: [PATCH 09/11] memcg: propagate kmem limiting information to children By: akpm on Tue, 26 June 2012 05:31
		Re: [PATCH 09/11] memcg: propagate kmem limiting information to children By: Glauber Costa on Tue, 26 June 2012 07:23
		[PATCH 08/11] memcg: disable kmem code when not in use. By: Glauber Costa on Mon, 25 June 2012 14:15
		Re: [PATCH 08/11] memcg: disable kmem code when not in use. By: KAMEZAWA Hiroyuki on Tue, 26 June 2012 05:51
		Re: [PATCH 00/11] kmem controller for memcg: stripped down version By: akpm on Mon, 25 June 2012 23:27
		Re: [PATCH 00/11] kmem controller for memcg: stripped down version By: Glauber Costa on Tue, 26 June 2012 07:17
		Re: [PATCH 00/11] kmem controller for memcg: stripped down version By: akpm on Tue, 26 June 2012 21:55
		Re: [PATCH 00/11] kmem controller for memcg: stripped down version By: David Rientjes on Wed, 27 June 2012 01:08
		Re: [PATCH 00/11] kmem controller for memcg: stripped down version By: Glauber Costa on Wed, 27 June 2012 08:39
		Fork bomb limitation in memcg WAS: Re: [PATCH 00/11] kmem controller for memcg: stripped down versio By: Glauber Costa on Wed, 27 June 2012 09:29
		Re: Fork bomb limitation in memcg WAS: Re: [PATCH 00/11] kmem controller for memcg: stripped down ve By: Frederic Weisbecker on Wed, 27 June 2012 12:29
		Re: Fork bomb limitation in memcg WAS: Re: [PATCH 00/11] kmem controller for memcg: stripped down ve By: Glauber Costa on Wed, 27 June 2012 12:28
		Re: Fork bomb limitation in memcg WAS: Re: [PATCH 00/11] kmem controller for memcg: stripped down ve By: Frederic Weisbecker on Wed, 27 June 2012 12:35
		Re: Fork bomb limitation in memcg WAS: Re: [PATCH 00/11] kmem controller for memcg: stripped down ve By: David Rientjes on Wed, 27 June 2012 19:38
		Re: Fork bomb limitation in memcg WAS: Re: [PATCH 00/11] kmem controller for memcg: stripped down ve By: Glauber Costa on Thu, 28 June 2012 09:01
		Re: Fork bomb limitation in memcg WAS: Re: [PATCH 00/11] kmem controller for memcg: stripped down ve By: akpm on Thu, 28 June 2012 22:25
		Re: Fork bomb limitation in memcg WAS: Re: [PATCH 00/11] kmem controller for memcg: stripped down ve By: Glauber Costa on Tue, 03 July 2012 11:38
		Re: Fork bomb limitation in memcg WAS: Re: [PATCH 00/11] kmem controller for memcg: stripped down ve By: Frederic Weisbecker on Thu, 12 July 2012 15:40
		Re: Fork bomb limitation in memcg WAS: Re: [PATCH 00/11] kmem controller for memcg: stripped down ve By: Glauber Costa on Tue, 07 August 2012 13:59
		Re: Fork bomb limitation in memcg WAS: Re: [PATCH 00/11] kmem controller for memcg: stripped down ve By: Glauber Costa on Wed, 08 August 2012 14:15

Previous Topic:	containers and cgroups mini-summit @ Linux Plumbers
Next Topic:	[PATCH 0/4] fuse: optimize scatter-gather direct IO

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Sat Jul 05 22:45:11 GMT 2025

Total time taken to generate the page: 0.02395 seconds