OpenVZ Forum: Devel » [PATCH 0/3] SUNRPC: separate per-net data creation from service creation

Home » Mailing lists » Devel » [PATCH 0/3] SUNRPC: separate per-net data creation from service creation

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

[PATCH 2/3] SUNRPC: check rpcbind clients usage counter before decrement [message #46078 is a reply to message #46076]

Wed, 25 April 2012 13:37

Stanislav Kinsbursky is currently offline

Stanislav Kinsbursky
Messages: 683
Registered: October 2011

Senior Member

Registering service with svc_bind() can fail. In this case service will be
destroyed and during destruction it will try to unregister itself from rpcbind.
In this case unregister have to be skipped.

Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com>

---
net/sunrpc/rpcb_clnt.c | 12 +++++++-----
1 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/net/sunrpc/rpcb_clnt.c b/net/sunrpc/rpcb_clnt.c
index 78ac39f..4c38b33 100644
--- a/net/sunrpc/rpcb_clnt.c
+++ b/net/sunrpc/rpcb_clnt.c
@@ -180,14 +180,16 @@ void rpcb_put_local(struct net *net)
struct sunrpc_net *sn = net_generic(net, sunrpc_net_id);
struct rpc_clnt *clnt = sn->rpcb_local_clnt;
struct rpc_clnt *clnt4 = sn->rpcb_local_clnt4;
- int shutdown;
+ int shutdown = 0;

spin_lock(&sn->rpcb_clnt_lock);
- if (--sn->rpcb_users == 0) {
- sn->rpcb_local_clnt = NULL;
- sn->rpcb_local_clnt4 = NULL;
+ if (sn->rpcb_users) {
+ if (--sn->rpcb_users == 0) {
+ sn->rpcb_local_clnt = NULL;
+ sn->rpcb_local_clnt4 = NULL;
+ }
+ shutdown = !sn->rpcb_users;
}
- shutdown = !sn->rpcb_users;
spin_unlock(&sn->rpcb_clnt_lock);

if (shutdown) {

Report message to a moderator

[Message index]

		[PATCH 0/3] SUNRPC: separate per-net data creation from service creation By: Stanislav Kinsbursky on Wed, 25 April 2012 13:37
		[PATCH 3/3] SUNRPC: move per-net operations from svc_destroy() By: Stanislav Kinsbursky on Wed, 25 April 2012 13:37
		[PATCH v2 3/3] SUNRPC: move per-net operations from svc_destroy() By: Stanislav Kinsbursky on Wed, 25 April 2012 14:00
		[PATCH 2/3] SUNRPC: check rpcbind clients usage counter before decrement By: Stanislav Kinsbursky on Wed, 25 April 2012 13:37
		Re: [PATCH 2/3] SUNRPC: check rpcbind clients usage counter before decrement By: bfields on Fri, 27 April 2012 13:55
		Re: [PATCH 2/3] SUNRPC: check rpcbind clients usage counter before decrement By: Stanislav Kinsbursky on Fri, 27 April 2012 14:08
		Re: [PATCH 2/3] SUNRPC: check rpcbind clients usage counter before decrement By: bfields on Mon, 30 April 2012 21:45
		Re: [PATCH 2/3] SUNRPC: check rpcbind clients usage counter before decrement By: Stanislav Kinsbursky on Tue, 01 May 2012 08:20
		[PATCH 1/3] SUNRPC: new svc_bind() routine introduced By: Stanislav Kinsbursky on Wed, 25 April 2012 13:37

Previous Topic:	[PATCH] NFS: get module in idmap PipeFS notifier callback
Next Topic:	[PATCH 00/23] slab+slub accounting for memcg

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Wed Oct 29 01:19:39 GMT 2025

Total time taken to generate the page: 0.24621 seconds