OpenVZ Forum: Devel » [PATCH 0/3] Fix problem with static

Home » Mailing lists » Devel » [PATCH 0/3] Fix problem with static_key decrement

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

Re: [PATCH 3/3] decrement static keys on real destroy time [message #45979 is a reply to message #45961]

Fri, 20 April 2012 19:39

Glauber Costa
Messages: 916
Registered: October 2011

Senior Member

On 04/20/2012 04:38 AM, KAMEZAWA Hiroyuki wrote:
>> mem_cgroup_get(memcg);
>> > - sk->sk_cgrp = sk->sk_prot->proto_cgroup(memcg);
>> > + sk->sk_cgrp = cg_proto;
>> > }
>
>
> Is this correct ? cg_proto->active can be true before all jump_labels are
> patched, then we can loose accounting. That will cause underflow of
> res_countner.
>
> cg_proto->active should be set after jump_label modification.
> Then, things will work, I guess.
>
> Thanks,
> -Kame
>

Kame,

You are right.

The first update needs to be done after the jump label activation as
well. I got myself confused with the two flags =(

I will repost with this fixed once I get into agreement with Tejun and
Li about the lockless ->destroy()

Report message to a moderator

[Message index]

		[PATCH 0/3] Fix problem with static_key decrement By: Glauber Costa on Thu, 19 April 2012 22:49
		[PATCH 2/3] don't take cgroup_mutex in destroy() By: Glauber Costa on Thu, 19 April 2012 22:49
		Re: [PATCH 2/3] don't take cgroup_mutex in destroy() By: Tejun Heo on Thu, 19 April 2012 22:57
		Re: [PATCH 2/3] don't take cgroup_mutex in destroy() By: Glauber Costa on Fri, 20 April 2012 15:04
		Re: [PATCH 2/3] don't take cgroup_mutex in destroy() By: Li Zefan on Sat, 21 April 2012 06:47
		Re: [PATCH 2/3] don't take cgroup_mutex in destroy() By: Glauber Costa on Mon, 23 April 2012 16:36
		Re: [PATCH 2/3] don't take cgroup_mutex in destroy() By: Li Zefan on Fri, 20 April 2012 00:30
		[PATCH 1/3] don't attach a task to a dead cgroup By: Glauber Costa on Thu, 19 April 2012 22:49
		Re: [PATCH 1/3] don't attach a task to a dead cgroup By: Tejun Heo on Thu, 19 April 2012 22:53
		Re: [PATCH 1/3] don't attach a task to a dead cgroup By: Glauber Costa on Fri, 20 April 2012 15:05
		[PATCH 3/3] decrement static keys on real destroy time By: Glauber Costa on Thu, 19 April 2012 22:49
		Re: [PATCH 3/3] decrement static keys on real destroy time By: KAMEZAWA Hiroyuki on Fri, 20 April 2012 07:38
		Re: [PATCH 3/3] decrement static keys on real destroy time By: Glauber Costa on Fri, 20 April 2012 19:39
		Re: [PATCH 0/3] Fix problem with static_key decrement By: Tejun Heo on Thu, 19 April 2012 22:54
		Re: [PATCH 0/3] Fix problem with static_key decrement By: Glauber Costa on Fri, 20 April 2012 15:01

Previous Topic:	[PATCH 3/3] SUNRPC: set per-net PipeFS superblock before notification
Next Topic:	[PATCH v2 0/5] Fix problem with static_key decrement

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Fri Sep 12 15:29:40 GMT 2025

Total time taken to generate the page: 0.08922 seconds