OpenVZ Forum: Devel » [PATCH 0/3] Fix problem with static

Home » Mailing lists » Devel » [PATCH 0/3] Fix problem with static_key decrement

Show: Today's Messages :: Show Polls :: Message Navigator
E-mail to friend

[PATCH 1/3] don't attach a task to a dead cgroup [message #45945 is a reply to message #45943]

Thu, 19 April 2012 22:49

Glauber Costa
Messages: 916
Registered: October 2011

Senior Member

Not all external callers of cgroup_attach_task() test to
see if the cgroup is still live - the internal callers at
cgroup.c does.

With this test in cgroup_attach_task, we can assure that
no tasks are ever moved to a cgroup that is past its
destruction point and was already marked as dead.

Signed-off-by: Glauber Costa <glommer@parallels.com>
CC: Tejun Heo <tj@kernel.org>
CC: Li Zefan <lizefan@huawei.com>
CC: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
---
kernel/cgroup.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index b61b938..932c318 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1927,6 +1927,9 @@ int cgroup_attach_task(struct cgroup *cgrp, struct task_struct *tsk)
struct cgroup_taskset tset = { };
struct css_set *newcg;

+ if (cgroup_is_removed(cgrp))
+ return -ENODEV;
+
/* @tsk either already exited or can't exit until the end */
if (tsk->flags & PF_EXITING)
return -ESRCH;
--
1.7.7.6

Report message to a moderator

[Message index]

		[PATCH 0/3] Fix problem with static_key decrement By: Glauber Costa on Thu, 19 April 2012 22:49
		[PATCH 2/3] don't take cgroup_mutex in destroy() By: Glauber Costa on Thu, 19 April 2012 22:49
		Re: [PATCH 2/3] don't take cgroup_mutex in destroy() By: Tejun Heo on Thu, 19 April 2012 22:57
		Re: [PATCH 2/3] don't take cgroup_mutex in destroy() By: Glauber Costa on Fri, 20 April 2012 15:04
		Re: [PATCH 2/3] don't take cgroup_mutex in destroy() By: Li Zefan on Sat, 21 April 2012 06:47
		Re: [PATCH 2/3] don't take cgroup_mutex in destroy() By: Glauber Costa on Mon, 23 April 2012 16:36
		Re: [PATCH 2/3] don't take cgroup_mutex in destroy() By: Li Zefan on Fri, 20 April 2012 00:30
		[PATCH 1/3] don't attach a task to a dead cgroup By: Glauber Costa on Thu, 19 April 2012 22:49
		Re: [PATCH 1/3] don't attach a task to a dead cgroup By: Tejun Heo on Thu, 19 April 2012 22:53
		Re: [PATCH 1/3] don't attach a task to a dead cgroup By: Glauber Costa on Fri, 20 April 2012 15:05
		[PATCH 3/3] decrement static keys on real destroy time By: Glauber Costa on Thu, 19 April 2012 22:49
		Re: [PATCH 3/3] decrement static keys on real destroy time By: KAMEZAWA Hiroyuki on Fri, 20 April 2012 07:38
		Re: [PATCH 3/3] decrement static keys on real destroy time By: Glauber Costa on Fri, 20 April 2012 19:39
		Re: [PATCH 0/3] Fix problem with static_key decrement By: Tejun Heo on Thu, 19 April 2012 22:54
		Re: [PATCH 0/3] Fix problem with static_key decrement By: Glauber Costa on Fri, 20 April 2012 15:01

Previous Topic:	[PATCH 3/3] SUNRPC: set per-net PipeFS superblock before notification
Next Topic:	[PATCH v2 0/5] Fix problem with static_key decrement

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

]

Current Time: Wed Nov 12 06:04:11 GMT 2025

Total time taken to generate the page: 0.11607 seconds